patch-2.3.99-pre3 linux/drivers/usb/wacom.c

Next file: linux/drivers/video/Makefile
Previous file: linux/drivers/usb/usb.c
Back to the patch index
Back to the overall index

diff -u --recursive --new-file v2.3.99-pre2/linux/drivers/usb/wacom.c linux/drivers/usb/wacom.c
@@ -1,5 +1,5 @@
 /*
- *  wacom.c  Version 0.4
+ *  wacom.c  Version 0.5
  *
  *  Copyright (c) 2000 Vojtech Pavlik		<vojtech@suse.cz>
  *  Copyright (c) 2000 Andreas Bach Aaen	<abach@stofanet.dk>
@@ -14,8 +14,10 @@
  *      v0.1 (vp)  - Initial release
  *      v0.2 (aba) - Support for all buttons / combinations
  *      v0.3 (vp)  - Support for Intuos added
- *      v0.4 (sm)  - Support for more Intuos models, menustrip,
- *                   relative mode, proximity.
+ *	v0.4 (sm)  - Support for more Intuos models, menustrip
+ *			relative mode, proximity.
+ *	v0.5 (vp)  - Big cleanup, nifty features removed,
+ * 			they belong in userspace
  */
 
 /*
@@ -50,16 +52,14 @@
 /*
  * Wacom Graphire packet:
  *
- * The input report:
- * 
  * byte 0: report ID (2)
- * byte 1: bit7 	mouse/pen/rubber near
- *         bit5-6	0 - pen, 1 - rubber, 2 - mouse
- * 	   bit4		1 ?
- *         bit3		0 ?
- *         bit2		mouse middle button / pen button2
- *         bit1		mouse right button / pen button1
- *         bit0		mouse left button / pen tip / rubber
+ * byte 1: bit7		pointer in range
+ *	   bit5-6	pointer type 0 - pen, 1 - rubber, 2 - mouse
+ *	   bit4		1 ?
+ *	   bit3		0 ?
+ *	   bit2		mouse middle button / pen button2
+ *	   bit1		mouse right button / pen button1
+ *	   bit0		mouse left button / touch
  * byte 2: X low bits
  * byte 3: X high bits
  * byte 4: Y low bits
@@ -69,115 +69,58 @@
  * 
  * There are also two single-byte feature reports (2 and 3).
  *
- * Resolution:
- * X: 0 - 10206
- * Y: 0 - 7422
- * 
- * (0,0) is upper left corner
- *
- * Wacom Intuos Status packet:
+ * Wacom Intuos status packet:
  *
- *  byte 0: report ID (2)
- *  byte 1: bit7	1 (Sync Byte)
- *          bit6	Pointer Near
- *          bit5	0 - first proximity report
- *          bit4 	0 ?
- *          bit3	0 ?
- *          bit2	pen button2
- *          bit1	pen button1
- *          bit0	0 ?
- *  byte 2: X high bits
- *  byte 3: X low bits
- *  byte 4: Y high bits
- *  byte 5: Y low bits
- *  byte 6: bits 0-7:  pressure (bits 2-9)
- *  byte 7: bits 6-7:  pressure (bits 0-1)
- *  byte 7: bits 0-5:  X tilt  (bits 1-6)
- *  byte 8: bit    7:  X tilt  (bit  0)
- *  byte 8: bits 0-6:  Y tilt  (bits 0-6)
- *  byte 9: bits 4-7:  Proximity
+ * byte 0: report ID (2)
+ * byte 1: bit7		1 - sync bit 
+ *	   bit6		pointer in range
+ *	   bit5		pointer type report
+ *	   bit4		0 ?
+ *	   bit3		0 ?
+ *	   bit2		pen button2
+ *	   bit1		pen button1
+ *	   bit0		0 ?
+ * byte 2: X high bits
+ * byte 3: X low bits
+ * byte 4: Y high bits
+ * byte 5: Y low bits
+ * byte 6: bits 0-7: pressure	(bits 2-9)
+ * byte 7: bits 6-7: pressure	(bits 0-1)
+ * byte 7: bits 0-5: X tilt	(bits 1-6)
+ * byte 8: bit    7: X tilt	(bit  0)
+ * byte 8: bits 0-6: Y tilt	(bits 0-6)
+ * byte 9: bits 4-7: distance
  */
 
-#define USB_VENDOR_ID_WACOM		0x056a
-#define USB_DEVICE_ID_WACOM_GRAPHIRE	0x0010
-#define USB_DEVICE_ID_WACOM_INTUOS45	0x0020 /* Guess */
-#define USB_DEVICE_ID_WACOM_INTUOS68	0x0021
-#define USB_DEVICE_ID_WACOM_INTUOS912	0x0022 /* Guess */
-#define USB_DEVICE_ID_WACOM_INTUOS1212	0x0023
-#define USB_DEVICE_ID_WACOM_INTUOS1218	0x0024 /* Guess */
-
-#define USB_TOOL_ID_WACOM_PEN	        0x0022
-#define USB_TOOL_ID_WACOM_ERASER        0x00fa
-#define USB_TOOL_ID_WACOM_STROKE_PEN    0x0032
-#define USB_TOOL_ID_WACOM_INKING_PEN    0x0012
-#define USB_TOOL_ID_WACOM_AIRBRUSH      0x0112
-#define USB_TOOL_ID_WACOM_MOUSE4D       0x0094
-#define USB_TOOL_ID_WACOM_LENS_CURSOR   0x0096
-
-#define INTUOS_PEN_MODE_ABS             0x00
-#define INTUOS_PEN_MODE_REL             0x01
-#define INTUOS_PEN_MODE_QUICKPOINT      0x02
-
-#define INTUOS_PRESSURE_MODE_SOFT       0x00
-#define INTUOS_PRESSURE_MODE_MED        0x01
-#define INTUOS_PRESSURE_MODE_FIRM       0x02
-
-#define INTUOS_MENUSTRIP_Y_ZONE         1400
-#define INTUOS_MENUSTRIP_BTN_YMIN        270
-#define INTUOS_MENUSTRIP_BTN_YMAX       1070
-#define INTUOS_MENUSTRIP_F1_XMIN          40
-#define INTUOS_MENUSTRIP_F7_XMIN        8340
-#define INTUOS_MENUSTRIP_F12_XMIN      15300
+#define USB_VENDOR_ID_WACOM	0x056a
 
-#define INTUOS_MENUSTRIP_BTN_WIDTH      1300
-
-#define INTUOS_MENUSTRIP_F7_IX_OFFSET      6 /* offset into wacom_fkeys */
-#define INTUOS_MENUSTRIP_F12_IX_OFFSET    11
+struct wacom_features {
+	char *name;
+	int idProduct;
+	int pktlen;
+	int x_max;
+	int y_max;
+	int pressure_max;
+	int distance_max;
+	void (*irq)(struct urb *urb);
+	unsigned long evbit;
+	unsigned long relbit;
+	unsigned long absbit;
+	unsigned long btnbit;
+	unsigned long digibit;
+};
 
 struct wacom {
-        signed char data[10];
+	signed char data[10];
 	struct input_dev dev;
 	struct urb irq;
-
-        int last_x, last_y;
-	unsigned int tool, device;
-	unsigned int ymax, menustrip_touch;
-	unsigned int pen_mode;
-	unsigned int pressure_mode;
+	struct wacom_features *features;
+	int tool;
 };
 
-static int wacom_fkeys[16] = { KEY_F1,  KEY_F2,  KEY_F3,  KEY_F4,
-			       KEY_F5,  KEY_F6,  KEY_F7,  KEY_F8,
-			       KEY_F9,  KEY_F10, KEY_F11, KEY_F12,
-			       KEY_F13, KEY_F14, KEY_F15, KEY_F16};
-
-#define INTUOS_EXTENTS_MAX_X              0x00
-#define INTUOS_EXTENTS_MAX_Y              0x01
-#define INTUOS_EXTENTS_HAS_F7             0x02
-#define INTUOS_EXTENTS_HAS_F12            0x03
-#define INTUOS_EXTENTS_PEN_MODE           0x04
-#define INTUOS_EXTENTS_HAS_QUICKPOINT     0x05
-#define INTUOS_EXTENTS_HAS_PRESSURE_MODE  0x06
-#define INTUOS_EXTENTS_PRESSURE_MODE      0x07
-
-#define WACOM_TRUE   1
-#define WACOM_FALSE  0
-
-static int intuos_extents[5][8] = {
-	{ 12700, 10360, WACOM_FALSE, WACOM_FALSE,  8340, WACOM_FALSE, WACOM_FALSE,     0},  /* Intuos 4x5   */
-	{ 20320, 15040,  WACOM_TRUE, WACOM_FALSE, 15300, WACOM_FALSE,  WACOM_TRUE, 18360},  /* Intuos 6x8   */
-	{ 30480, 23060,  WACOM_TRUE,  WACOM_TRUE, 22280,  WACOM_TRUE,  WACOM_TRUE, 26640},  /* Intuos 9x12  */
-	{ 30480, 30480,  WACOM_TRUE,  WACOM_TRUE, 22280,  WACOM_TRUE,  WACOM_TRUE, 26640},  /* Intuos 12x12 */
-	{ 47720, 30480,  WACOM_TRUE,  WACOM_TRUE, 29260,  WACOM_TRUE,  WACOM_TRUE, 33620}}; /* Intuos 12x18 */
-
-static char intuos_names[5][12] = {
-	{"Intuos 4x5  "}, {"Intuos 6x8  "},
-	{"Intuos 9x12 "}, {"Intuos 12x12"},
-	{"Intuos 12x18"}};
-
 static void wacom_graphire_irq(struct urb *urb)
 {
-        struct wacom *wacom = urb->context;
+	struct wacom *wacom = urb->context;
 	unsigned char *data = wacom->data;
 	struct input_dev *dev = &wacom->dev;
 
@@ -186,285 +129,135 @@
 	if (data[0] != 2)
 		dbg("received unknown report #%d", data[0]);
 
-        if ( data[1] & 0x80 ) {
-	        input_report_abs(dev, ABS_X, data[2] | ((__u32)data[3] << 8));
-	        input_report_abs(dev, ABS_Y, 7422 - (data[4] | ((__u32)data[5] << 8)));
+	if ( data[1] & 0x80 ) {
+		input_report_abs(dev, ABS_X, data[2] | ((__u32)data[3] << 8));
+		input_report_abs(dev, ABS_Y, data[4] | ((__u32)data[5] << 8));
 	}
 
 	switch ((data[1] >> 5) & 3) {
 
-	case 0:	/* Pen */
-		input_report_btn(dev, BTN_TOOL_PEN, data[1] & 0x80);
-		input_report_btn(dev, BTN_TOUCH, data[1] & 0x01);
-		input_report_btn(dev, BTN_STYLUS, data[1] & 0x02);
-		input_report_btn(dev, BTN_STYLUS2, data[1] & 0x04);
-		input_report_abs(dev, ABS_PRESSURE, data[6] | ((__u32)data[7] << 8));
-		break;
-
-	case 1: /* Rubber */
-		input_report_btn(dev, BTN_TOOL_RUBBER, data[1] & 0x80);
-		input_report_btn(dev, BTN_TOUCH, data[1] & 0x01);
-		input_report_btn(dev, BTN_STYLUS, data[1] & 0x02);
-		input_report_btn(dev, BTN_STYLUS2, data[1] & 0x04);
-		input_report_abs(dev, ABS_PRESSURE, data[6] | ((__u32)data[7] << 8));
-		break;
-
-	case 2: /* Mouse */
-		input_report_btn(dev, BTN_TOOL_MOUSE, data[7] > 24);
-		input_report_btn(dev, BTN_LEFT, data[1] & 0x01);
-		input_report_btn(dev, BTN_RIGHT, data[1] & 0x02);
-		input_report_btn(dev, BTN_MIDDLE, data[1] & 0x04);
-		input_report_abs(dev, ABS_DISTANCE, data[7]);
-		input_report_rel(dev, REL_WHEEL, (signed char) data[6]);
-		break;
-	}
-}
+		case 0:	/* Pen */
+			input_report_btn(dev, BTN_TOOL_PEN, data[1] & 0x80);
+			break;
 
-static void intuos_menustrip( unsigned int x, unsigned int y, struct wacom *wacom )
-{
-	struct input_dev *dev = &wacom->dev;
-	unsigned int local_x = x;
-	unsigned int local_y = y - ( wacom->ymax - INTUOS_MENUSTRIP_Y_ZONE );
-	unsigned int fkey_index ;
-
-	/* Ensure we are in the vertical strip for the buttons */
-	if ( (local_y > INTUOS_MENUSTRIP_BTN_YMIN) && (local_y < INTUOS_MENUSTRIP_BTN_YMAX) ) {
-
-		/* Handle Pressure Mode */
-		if ( intuos_extents[wacom->device][INTUOS_EXTENTS_HAS_PRESSURE_MODE] ) {
-			int pressure_mode = ( (local_x - intuos_extents[wacom->device][INTUOS_EXTENTS_PRESSURE_MODE])
-					      / INTUOS_MENUSTRIP_BTN_WIDTH );
-			if ( ( pressure_mode >= INTUOS_PRESSURE_MODE_SOFT ) &&
-			     ( pressure_mode <= INTUOS_PRESSURE_MODE_FIRM ) ) {
-				wacom->pressure_mode = pressure_mode;
-				return;
-			}
-		}
-
-		/* Handle Pen Mode */
-		{
-			int pen_mode = ( (local_x - intuos_extents[wacom->device][INTUOS_EXTENTS_PEN_MODE])
-					 / INTUOS_MENUSTRIP_BTN_WIDTH );
-			if ( ( pen_mode == INTUOS_PEN_MODE_ABS ) ||
-			     ( pen_mode == INTUOS_PEN_MODE_REL ) ||
-			     ( ( pen_mode == INTUOS_PEN_MODE_QUICKPOINT ) &&
-			       ( intuos_extents[wacom->device][INTUOS_EXTENTS_HAS_QUICKPOINT] ) ) ) {
-				wacom->pen_mode = pen_mode;
-				return;
-			}
-		}
-
-		/* Handle Function Keys */
-		if ( local_x > INTUOS_MENUSTRIP_F12_XMIN ) {
-			fkey_index = INTUOS_MENUSTRIP_F12_IX_OFFSET
-				+ ( (local_x - INTUOS_MENUSTRIP_F12_XMIN) / INTUOS_MENUSTRIP_BTN_WIDTH );
-			fkey_index = ( fkey_index > 16 ) ? 16 : fkey_index; /* Ensure in range */
-		}
-		else if ( local_x > INTUOS_MENUSTRIP_F7_XMIN ) {
-			fkey_index = INTUOS_MENUSTRIP_F7_IX_OFFSET
-				+ ( (local_x - INTUOS_MENUSTRIP_F7_XMIN) / INTUOS_MENUSTRIP_BTN_WIDTH );
-			fkey_index = ( fkey_index > 11 ) ? 11 : fkey_index;
-		}
-		else {
-			fkey_index = ( (local_x - INTUOS_MENUSTRIP_F1_XMIN) / INTUOS_MENUSTRIP_BTN_WIDTH );
-			fkey_index = ( fkey_index > 6 ) ? 6 : fkey_index;
-		}
-		input_report_key(dev, wacom_fkeys[fkey_index], 1);
-		input_report_key(dev, wacom_fkeys[fkey_index], 0);
+		case 1: /* Rubber */
+			input_report_btn(dev, BTN_TOOL_RUBBER, data[1] & 0x80);
+			break;
 
-		return;
+		case 2: /* Mouse */
+			input_report_btn(dev, BTN_TOOL_MOUSE, data[7] > 24);
+			input_report_btn(dev, BTN_LEFT, data[1] & 0x01);
+			input_report_btn(dev, BTN_RIGHT, data[1] & 0x02);
+			input_report_btn(dev, BTN_MIDDLE, data[1] & 0x04);
+			input_report_abs(dev, ABS_DISTANCE, data[7]);
+			input_report_rel(dev, REL_WHEEL, (signed char) data[6]);
+			return;
 	}
+
+	input_report_abs(dev, ABS_PRESSURE, data[6] | ((__u32)data[7] << 8));
+
+	input_report_btn(dev, BTN_TOUCH, data[1] & 0x01);
+	input_report_btn(dev, BTN_STYLUS, data[1] & 0x02);
+	input_report_btn(dev, BTN_STYLUS2, data[1] & 0x04);
 }
-		
+
 static void wacom_intuos_irq(struct urb *urb)
 {
-        struct wacom *wacom = urb->context;
+	struct wacom *wacom = urb->context;
 	unsigned char *data = wacom->data;
 	struct input_dev *dev = &wacom->dev;
 	unsigned int t;
-	int x, y;
 
 	if (urb->status) return;
 
 	if (data[0] != 2)
 		dbg("received unknown report #%d", data[0]);
 
-	if ( ((data[1] >> 5) & 0x3) == 0x2 ) /* First record, feature report */
-		{
-			wacom->tool = (((char)data[2] << 4) | (char)data[3] >> 4) & 0xff ;
-			/* Report tool type */
-			switch ( wacom->tool )	{
-			case USB_TOOL_ID_WACOM_PEN: 
-				input_report_btn(dev, BTN_TOOL_PEN, 1);
-				break;
-			case USB_TOOL_ID_WACOM_ERASER: 
-				input_report_btn(dev, BTN_TOOL_RUBBER, 1);
-				break;
-			case USB_TOOL_ID_WACOM_STROKE_PEN: 
-				input_report_btn(dev, BTN_TOOL_BRUSH, 1);
-				break;
-			case USB_TOOL_ID_WACOM_INKING_PEN: 
-				input_report_btn(dev, BTN_TOOL_PENCIL, 1);
-				break;
-			case USB_TOOL_ID_WACOM_AIRBRUSH: 
-				input_report_btn(dev, BTN_TOOL_AIRBRUSH, 1);
-				break;
-			case USB_TOOL_ID_WACOM_MOUSE4D: 
-			case USB_TOOL_ID_WACOM_LENS_CURSOR: 
-				input_report_btn(dev, BTN_TOOL_MOUSE, 1);
-				break;
-			default:
-				break;
-			}			
-			return;
-		}
+	if (((data[1] >> 5) & 0x3) == 0x2) {				/* Enter report */
 
-	if ( ( data[1] | data[2] | data[3] | data[4] | data[5] | data[6]
-	       | data[7] | data[8] | data[9] ) == 0x80 ) { /* exit report */
-		switch ( wacom->tool ) {
-		case USB_TOOL_ID_WACOM_PEN: 
-			input_report_btn(dev, BTN_TOOL_PEN, 0);
-			break;
-		case USB_TOOL_ID_WACOM_ERASER: 
-			input_report_btn(dev, BTN_TOOL_RUBBER, 0);
-			break;
-		case USB_TOOL_ID_WACOM_STROKE_PEN: 
-			input_report_btn(dev, BTN_TOOL_BRUSH, 0);
-			break;
-		case USB_TOOL_ID_WACOM_INKING_PEN: 
-			input_report_btn(dev, BTN_TOOL_PENCIL, 0);
-			break;
-		case USB_TOOL_ID_WACOM_AIRBRUSH: 
-			input_report_btn(dev, BTN_TOOL_AIRBRUSH, 0);
-			break;
-		case USB_TOOL_ID_WACOM_MOUSE4D: 
-		case USB_TOOL_ID_WACOM_LENS_CURSOR: 
-			input_report_btn(dev, BTN_TOOL_MOUSE, 0);
-			break;
-		default:
-			break;
+		switch (((__u32)data[2] << 4) | (data[3] >> 4)) {
+			case 0x012: wacom->tool = BTN_TOOL_PENCIL;	break;	/* Inking pen */
+			case 0x022: wacom->tool = BTN_TOOL_PEN;		break;	/* Pen */
+			case 0x032: wacom->tool = BTN_TOOL_BRUSH;	break;	/* Stroke pen */
+			case 0x094: wacom->tool = BTN_TOOL_MOUSE;	break;	/* Mouse 4D */
+			case 0x096: wacom->tool = BTN_TOOL_LENS;	break;	/* Lens cursor */
+			case 0x0fa: wacom->tool = BTN_TOOL_RUBBER;	break;	/* Eraser */
+			case 0x112: wacom->tool = BTN_TOOL_AIRBRUSH;	break;	/* Airbrush */
+			default:    wacom->tool = BTN_TOOL_PEN;		break;	/* Unknown tool */
 		}			
+		input_report_btn(dev, wacom->tool, 1);
 		return;
 	}
 
-	x = (((unsigned int) data[2]) << 8) | data[3] ;
-	y = wacom->dev.absmax[ABS_Y] - ((((unsigned int) data[4]) << 8) | data[5]);
-
-	t = (((unsigned int) data[6]) << 2) | ((data[7] & 0xC0) >> 6);
-
-	/* Handle touch near menustrip */
-	if ( y > ( wacom->dev.absmax[ABS_Y] - INTUOS_MENUSTRIP_Y_ZONE ) ) {
-		if ( t > 10 ) /* Touch */
-			wacom->menustrip_touch = 1;
-		if ( (wacom->menustrip_touch) && (t <= 10) ) { /* Pen Up */
-			intuos_menustrip( x, y, wacom );
-			wacom->menustrip_touch = 0;
-		}
+	if ((data[1] | data[2] | data[3] | data[4] | data[5] |
+	     data[6] | data[7] | data[8] | data[9]) == 0x80) {		/* Exit report */
+		input_report_btn(dev, wacom->tool, 0);
 		return;
 	}
-	else
-		wacom->menustrip_touch = 0;
 
-	switch ( wacom->pen_mode ) {
-	case INTUOS_PEN_MODE_ABS:
-	        input_report_abs(dev, ABS_X, x);
-		input_report_abs(dev, ABS_Y, y);
-		break;
-	case INTUOS_PEN_MODE_REL:
-	        input_report_rel(dev, REL_X, ( x - wacom->last_x) / 8 );
-	        input_report_rel(dev, REL_Y, - ( y - wacom->last_y) / 8 );
-		break;
-	default: break;
-	}
-
-	wacom->last_x = x;
-	wacom->last_y = y;
-
-	input_report_btn(dev, BTN_STYLUS, data[1] & 0x02);
-	input_report_btn(dev, BTN_STYLUS2, data[1] & 0x04);
+	input_report_abs(dev, ABS_X, ((__u32)data[2] << 8) | data[3]);
+	input_report_abs(dev, ABS_Y, ((__u32)data[4] << 8) | data[5]);
+	input_report_abs(dev, ABS_PRESSURE, t = ((__u32)data[6] << 2) | ((data[7] >> 6) & 3));
+	input_report_abs(dev, ABS_DISTANCE, data[9] >> 4);
+	input_report_abs(dev, ABS_TILT_X, ((data[7] << 1) & 0x7e) | (data[8] >> 7));
+	input_report_abs(dev, ABS_TILT_Y, data[8] & 0x7f);
 
+	input_report_btn(dev, BTN_STYLUS, data[1] & 2);
+	input_report_btn(dev, BTN_STYLUS2, data[1] & 4);
 	input_report_btn(dev, BTN_TOUCH, t > 10);
-	input_report_abs(dev, ABS_PRESSURE, t);
-
-	input_report_abs(dev, ABS_DISTANCE, ( data[9] & 0xf0 ) >> 4 );
+}
 
-	input_report_abs(dev, ABS_TILT_X, ((((unsigned int) data[7]) & 0x3f) << 1) | ((data[8] & 0x80) >> 7));
-	input_report_abs(dev, ABS_TILT_Y, data[8] & 0x7f);
+#define WACOM_INTUOS_TOOLS	(BIT(BTN_TOOL_BRUSH) | BIT(BTN_TOOL_PENCIL) | BIT(BTN_TOOL_AIRBRUSH) | BIT(BTN_TOOL_LENS))
 
-}
+struct wacom_features wacom_features[] = {
+	{ "Graphire",     0x10,  8, 10206,  7422,  511, 32, wacom_graphire_irq,
+		BIT(EV_REL), 0, BIT(REL_WHEEL), BIT(BTN_LEFT) | BIT(BTN_RIGHT) | BIT(BTN_MIDDLE), 0 },
+	{ "Intuos 4x5",   0x20, 10, 12700, 10360, 1023, 15, wacom_intuos_irq,
+		0, BIT(ABS_TILT_X) | BIT(ABS_TILT_Y), 0, 0, WACOM_INTUOS_TOOLS },
+	{ "Intuos 6x8",   0x21, 10, 20320, 15040, 1023, 15, wacom_intuos_irq,
+		0, BIT(ABS_TILT_X) | BIT(ABS_TILT_Y), 0, 0, WACOM_INTUOS_TOOLS },
+	{ "Intuos 9x12",  0x22, 10, 30480, 23060, 1023, 15, wacom_intuos_irq,
+		0, BIT(ABS_TILT_X) | BIT(ABS_TILT_Y), 0, 0, WACOM_INTUOS_TOOLS },
+	{ "Intuos 12x12", 0x23, 10, 30480, 30480, 1023, 15, wacom_intuos_irq,
+		0, BIT(ABS_TILT_X) | BIT(ABS_TILT_Y), 0, 0, WACOM_INTUOS_TOOLS },
+	{ "Intuos 12x18", 0x24, 10, 47720, 30480, 1023, 15, wacom_intuos_irq,
+		0, BIT(ABS_TILT_X) | BIT(ABS_TILT_Y), 0, 0, WACOM_INTUOS_TOOLS },
+	{ NULL , 0 }
+};
 
 static void *wacom_probe(struct usb_device *dev, unsigned int ifnum)
 {
 	struct usb_endpoint_descriptor *endpoint;
 	struct wacom *wacom;
-	char *name;
+	int i;
 
-	if (dev->descriptor.idVendor != USB_VENDOR_ID_WACOM ||
-	    (dev->descriptor.idProduct != USB_DEVICE_ID_WACOM_GRAPHIRE &&
-	     dev->descriptor.idProduct != USB_DEVICE_ID_WACOM_INTUOS45 &&
-	     dev->descriptor.idProduct != USB_DEVICE_ID_WACOM_INTUOS68 &&
-	     dev->descriptor.idProduct != USB_DEVICE_ID_WACOM_INTUOS912 &&
-	     dev->descriptor.idProduct != USB_DEVICE_ID_WACOM_INTUOS1212 &&
-	     dev->descriptor.idProduct != USB_DEVICE_ID_WACOM_INTUOS1218))
-		return NULL;
+	if (dev->descriptor.idVendor != USB_VENDOR_ID_WACOM) return NULL;
+	for (i = 0; wacom_features[i].idProduct && wacom_features[i].idProduct != dev->descriptor.idProduct; i++);
+	if (!wacom_features[i].idProduct) return NULL;
 
 	endpoint = dev->config[0].interface[ifnum].altsetting[0].endpoint + 0;
 
 	if (!(wacom = kmalloc(sizeof(struct wacom), GFP_KERNEL))) return NULL;
 	memset(wacom, 0, sizeof(struct wacom));
 
-	if ( dev->descriptor.idProduct == USB_DEVICE_ID_WACOM_GRAPHIRE ) {
-		wacom->dev.evbit[0] |= BIT(EV_KEY) | BIT(EV_REL) | BIT(EV_ABS);
-		wacom->dev.keybit[LONG(BTN_MOUSE)] |= BIT(BTN_LEFT) | BIT(BTN_RIGHT) | BIT(BTN_MIDDLE);
-		wacom->dev.keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOOL_PEN) | BIT(BTN_TOOL_RUBBER) | BIT(BTN_TOOL_MOUSE);
-		wacom->dev.keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOUCH) | BIT(BTN_STYLUS) | BIT(BTN_STYLUS2);
-		wacom->dev.relbit[0] |= BIT(REL_WHEEL);
-		wacom->dev.absbit[0] |= BIT(ABS_X) | BIT(ABS_Y) | BIT(ABS_PRESSURE) | BIT(ABS_DISTANCE);
-
-		wacom->dev.absmax[ABS_X] = 10206;
-		wacom->dev.absmax[ABS_Y] = 7422;
-		wacom->dev.absmax[ABS_PRESSURE] = 511;
-		wacom->dev.absmax[ABS_DISTANCE] = 32;
+	wacom->features = wacom_features + i;
 
-		FILL_INT_URB(&wacom->irq, dev, usb_rcvintpipe(dev, endpoint->bEndpointAddress),
-			     wacom->data, 8, wacom_graphire_irq, wacom, endpoint->bInterval);
+	wacom->dev.evbit[0] |= BIT(EV_KEY) | BIT(EV_ABS) | wacom->features->evbit;
+	wacom->dev.absbit[0] |= BIT(ABS_X) | BIT(ABS_Y) | BIT(ABS_PRESSURE) | BIT(ABS_DISTANCE) | wacom->features->absbit;
+	wacom->dev.relbit[0] |= wacom->features->relbit;
+	wacom->dev.keybit[LONG(BTN_LEFT)] |= wacom->features->btnbit;
+	wacom->dev.keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOOL_PEN) | BIT(BTN_TOOL_RUBBER) | BIT(BTN_TOOL_MOUSE) |
+		BIT(BTN_TOUCH) | BIT(BTN_STYLUS) | BIT(BTN_STYLUS2) | wacom->features->digibit;
+
+	wacom->dev.absmax[ABS_X] = wacom->features->x_max;
+	wacom->dev.absmax[ABS_Y] = wacom->features->y_max;
+	wacom->dev.absmax[ABS_PRESSURE] = wacom->features->pressure_max;
+	wacom->dev.absmax[ABS_DISTANCE] = wacom->features->distance_max;
+	wacom->dev.absmax[ABS_TILT_X] = 127;
+	wacom->dev.absmax[ABS_TILT_Y] = 127;
 
-		name = "Graphire";
-	}
-	else { /* Intuos */
-
-		wacom->dev.evbit[0] |= BIT(EV_KEY) | BIT(EV_ABS) | BIT(EV_REL);
-		wacom->dev.keybit[LONG(KEY_F1)]  |= BIT(KEY_F1)  | BIT(KEY_F2)  | BIT(KEY_F3)  | BIT(KEY_F4) | BIT(KEY_F5);
-		wacom->dev.keybit[LONG(KEY_F6)]  |= BIT(KEY_F6)  | BIT(KEY_F7)  | BIT(KEY_F8);
-		wacom->dev.keybit[LONG(KEY_F9)]  |= BIT(KEY_F9)  | BIT(KEY_F10) | BIT(KEY_F11) | BIT(KEY_F12);
-		wacom->dev.keybit[LONG(KEY_F13)] |= BIT(KEY_F13) | BIT(KEY_F14) | BIT(KEY_F15) | BIT(KEY_F16);
-		wacom->dev.keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOUCH) | BIT(BTN_STYLUS) | BIT(BTN_STYLUS2);
-		wacom->dev.keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOOL_PEN) | BIT(BTN_TOOL_RUBBER) | BIT(BTN_TOOL_BRUSH);
-		wacom->dev.keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOOL_PENCIL) | BIT(BTN_TOOL_AIRBRUSH) | BIT(BTN_TOOL_MOUSE);
-		wacom->dev.absbit[0] |= BIT(ABS_X) | BIT(ABS_Y) | BIT(ABS_PRESSURE) | BIT(ABS_DISTANCE);
-		wacom->dev.absbit[0] |= BIT(ABS_TILT_X) | BIT(ABS_TILT_Y);
-		wacom->dev.relbit[0] |= BIT(REL_X) | BIT(REL_Y);
-
-		wacom->dev.absmax[ABS_PRESSURE] = 1023;
-		wacom->dev.absmax[ABS_DISTANCE] = 15;
-		wacom->dev.absmax[ABS_TILT_X] = 127;
-		wacom->dev.absmax[ABS_TILT_Y] = 127;
-
-		wacom->device = dev->descriptor.idProduct - USB_DEVICE_ID_WACOM_INTUOS45;
-
-		wacom->dev.absmax[ABS_X] = intuos_extents[wacom->device][INTUOS_EXTENTS_MAX_X];
-		wacom->dev.absmax[ABS_Y] = intuos_extents[wacom->device][INTUOS_EXTENTS_MAX_Y];
-
-		wacom->ymax = intuos_extents[wacom->device][INTUOS_EXTENTS_MAX_Y];
-		wacom->pen_mode = INTUOS_PEN_MODE_ABS;
-		wacom->pressure_mode = INTUOS_PRESSURE_MODE_SOFT;
-
-		name = intuos_names[wacom->device];
-
-		FILL_INT_URB(&wacom->irq, dev, usb_rcvintpipe(dev, endpoint->bEndpointAddress),
-			     wacom->data, 10, wacom_intuos_irq, wacom, endpoint->bInterval);
-
-	}
+	FILL_INT_URB(&wacom->irq, dev, usb_rcvintpipe(dev, endpoint->bEndpointAddress),
+		     wacom->data, wacom->features->pktlen, wacom->features->irq, wacom, endpoint->bInterval);
 
 	if (usb_submit_urb(&wacom->irq)) {
 		kfree(wacom);
@@ -473,7 +266,7 @@
 
 	input_register_device(&wacom->dev);
 
-	printk(KERN_INFO "input%d: Wacom %s\n", wacom->dev.number, name);
+	printk(KERN_INFO "input%d: Wacom %s on usb%d\n", wacom->dev.number, wacom->features->name, dev->devnum);
 
 	return wacom;
 }

FUNET's LINUX-ADM group, linux-adm@nic.funet.fi
TCL-scripts by Sam Shen (who was at: slshen@lbl.gov)