patch-2.3.99-pre6 linux/net/atm/mpc.c

Next file: linux/net/atm/mpoa_caches.c
Previous file: linux/net/atm/lec.h
Back to the patch index
Back to the overall index

diff -u --recursive --new-file v2.3.99-pre5/linux/net/atm/mpc.c linux/net/atm/mpc.c
@@ -62,7 +62,7 @@
 static void set_mps_mac_addr_rcvd(struct k_message *mesg, struct mpoa_client *mpc);
 
 static uint8_t *copy_macs(struct mpoa_client *mpc, uint8_t *router_mac,
-                          uint8_t *tlvs, uint8_t mps_macs, uint8_t device_type);
+			  uint8_t *tlvs, uint8_t mps_macs, uint8_t device_type);
 static void purge_egress_shortcut(struct atm_vcc *vcc, eg_cache_entry *entry);
 
 static void send_set_mps_ctrl_addr(char *addr, struct mpoa_client *mpc);
@@ -76,25 +76,25 @@
 static void mpc_cache_check( unsigned long checking_time  );
 
 static struct llc_snap_hdr llc_snap_mpoa_ctrl = {
-        0xaa, 0xaa, 0x03,
-        {0x00, 0x00, 0x5e},
-        {0x00, 0x03}         /* For MPOA control PDUs */
+	0xaa, 0xaa, 0x03,
+	{0x00, 0x00, 0x5e},
+	{0x00, 0x03}         /* For MPOA control PDUs */
 };        
 static struct llc_snap_hdr llc_snap_mpoa_data = {
-        0xaa, 0xaa, 0x03,
-        {0x00, 0x00, 0x00},
-        {0x08, 0x00}         /* This is for IP PDUs only */
+	0xaa, 0xaa, 0x03,
+	{0x00, 0x00, 0x00},
+	{0x08, 0x00}         /* This is for IP PDUs only */
 };        
 static struct llc_snap_hdr llc_snap_mpoa_data_tagged = {
-        0xaa, 0xaa, 0x03,
-        {0x00, 0x00, 0x00},
-        {0x88, 0x4c}         /* This is for tagged data PDUs */
+	0xaa, 0xaa, 0x03,
+	{0x00, 0x00, 0x00},
+	{0x88, 0x4c}         /* This is for tagged data PDUs */
 };        
 
 static struct notifier_block mpoa_notifier = {
-        mpoa_event_listener,
-        NULL,
-        0
+	mpoa_event_listener,
+	NULL,
+	0
 };
 
 #ifdef CONFIG_PROC_FS
@@ -109,44 +109,44 @@
 
 static struct mpoa_client *find_mpc_by_itfnum(int itf)
 {
-        struct mpoa_client *mpc;
-        
-        mpc = mpcs;  /* our global linked list */
-        while (mpc != NULL) {
-                if (mpc->dev_num == itf)
-                        return mpc;
-                mpc = mpc->next;    
-        }
+	struct mpoa_client *mpc;
+	
+	mpc = mpcs;  /* our global linked list */
+	while (mpc != NULL) {
+		if (mpc->dev_num == itf)
+			return mpc;
+		mpc = mpc->next;    
+	}
 
-        return NULL;   /* not found */
+	return NULL;   /* not found */
 }
 
 static struct mpoa_client *find_mpc_by_vcc(struct atm_vcc *vcc)
 {
-        struct mpoa_client *mpc;
-        
-        mpc = mpcs;  /* our global linked list */
-        while (mpc != NULL) {
-                if (mpc->mpoad_vcc == vcc)
-                        return mpc;
-                mpc = mpc->next;
-        }
+	struct mpoa_client *mpc;
+	
+	mpc = mpcs;  /* our global linked list */
+	while (mpc != NULL) {
+		if (mpc->mpoad_vcc == vcc)
+			return mpc;
+		mpc = mpc->next;
+	}
 
-        return NULL;   /* not found */
+	return NULL;   /* not found */
 }
 
 static struct mpoa_client *find_mpc_by_lec(struct net_device *dev)
 {
-        struct mpoa_client *mpc;
-        
-        mpc = mpcs;  /* our global linked list */
-        while (mpc != NULL) {
-                if (mpc->dev == dev)
-                        return mpc;
-                mpc = mpc->next;
-        }
+	struct mpoa_client *mpc;
+	
+	mpc = mpcs;  /* our global linked list */
+	while (mpc != NULL) {
+		if (mpc->dev == dev)
+			return mpc;
+		mpc = mpc->next;
+	}
 
-        return NULL;   /* not found */
+	return NULL;   /* not found */
 }
 
 /*
@@ -158,42 +158,42 @@
  */
 struct atm_mpoa_qos *atm_mpoa_add_qos(uint32_t dst_ip, struct atm_qos *qos)
 {
-        struct atm_mpoa_qos *entry;
+	struct atm_mpoa_qos *entry;
 
-        entry = atm_mpoa_search_qos(dst_ip);
-        if (entry != NULL) {
-                entry->qos = *qos;
-                return entry;
-        }
-
-        entry = kmalloc(sizeof(struct atm_qos), GFP_KERNEL);
-        if (entry == NULL) {
-                printk("mpoa: atm_mpoa_add_qos: out of memory\n");
-                return entry;
-        }
+	entry = atm_mpoa_search_qos(dst_ip);
+	if (entry != NULL) {
+		entry->qos = *qos;
+		return entry;
+	}
 
-        entry->ipaddr = dst_ip;
-        entry->qos = *qos;
+	entry = kmalloc(sizeof(struct atm_qos), GFP_KERNEL);
+	if (entry == NULL) {
+		printk("mpoa: atm_mpoa_add_qos: out of memory\n");
+		return entry;
+	}
 
-        entry->next = qos_head;
-        qos_head = entry;
+	entry->ipaddr = dst_ip;
+	entry->qos = *qos;
 
-        return entry;
+	entry->next = qos_head;
+	qos_head = entry;
+
+	return entry;
 }
 
 struct atm_mpoa_qos *atm_mpoa_search_qos(uint32_t dst_ip)
 {
-        struct atm_mpoa_qos *qos;
+	struct atm_mpoa_qos *qos;
 
-        qos = qos_head;
-        while( qos != NULL ){
-                if(qos->ipaddr == dst_ip) {
-                        break;
+	qos = qos_head;
+	while( qos != NULL ){
+		if(qos->ipaddr == dst_ip) {
+			break;
 		}
-                qos = qos->next;
-        }
+		qos = qos->next;
+	}
 
-        return qos;
+	return qos;
 }        
 
 /*
@@ -202,26 +202,26 @@
 int atm_mpoa_delete_qos(struct atm_mpoa_qos *entry)
 {
 
-        struct atm_mpoa_qos *curr;
+	struct atm_mpoa_qos *curr;
 
-        if (entry == NULL) return 0;
-        if (entry == qos_head) {
-                qos_head = qos_head->next;
-                kfree(entry);
-                return 1;
-        }
-
-        curr = qos_head;
-        while (curr != NULL) {
-                if (curr->next == entry) {
-                        curr->next = entry->next;
-                        kfree(entry);
-                        return 1;
-                }
-                curr = curr->next;
-        }
+	if (entry == NULL) return 0;
+	if (entry == qos_head) {
+		qos_head = qos_head->next;
+		kfree(entry);
+		return 1;
+	}
 
-        return 0;
+	curr = qos_head;
+	while (curr != NULL) {
+		if (curr->next == entry) {
+			curr->next = entry->next;
+			kfree(entry);
+			return 1;
+		}
+		curr = curr->next;
+	}
+
+	return 0;
 }
 
 void atm_mpoa_disp_qos(char *page, int *len)
@@ -238,9 +238,9 @@
 	ipaddr[sizeof(ipaddr)-1] = '\0';
 	while (qos != NULL) {
 		ip = (unsigned char *)&qos->ipaddr;
-		sprintf(ipaddr, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]);
-		*len += sprintf(page + *len, "%-16s\n     %-7d %-7d %-7d %-7d %-7d\n     %-7d %-7d %-7d %-7d %-7d\n",
-				ipaddr,
+		sprintf(ipaddr, "%u.%u.%u.%u", NIPQUAD(ip));
+		*len += sprintf(page + *len, "%%u.%u.%u.%u\n     %-7d %-7d %-7d %-7d %-7d\n     %-7d %-7d %-7d %-7d %-7d\n",
+				NIPQUAD(ipaddr),
 				qos->qos.txtp.max_pcr, qos->qos.txtp.pcr, qos->qos.txtp.min_pcr, qos->qos.txtp.max_cdv, qos->qos.txtp.max_sdu,
 				qos->qos.rxtp.max_pcr, qos->qos.rxtp.pcr, qos->qos.rxtp.min_pcr, qos->qos.rxtp.max_cdv, qos->qos.rxtp.max_sdu);
 		qos = qos->next;
@@ -251,28 +251,26 @@
 
 static struct net_device *find_lec_by_itfnum(int itf)
 {
-        extern struct atm_lane_ops atm_lane_ops; /* in common.c */
-        
-        if (atm_lane_ops.get_lecs == NULL)
-                return NULL;
+	extern struct atm_lane_ops atm_lane_ops; /* in common.c */
+	
+	if (atm_lane_ops.get_lecs == NULL)
+		return NULL;
 
-        return atm_lane_ops.get_lecs()[itf]; /* FIXME: something better */
+	return atm_lane_ops.get_lecs()[itf]; /* FIXME: something better */
 }
 
 static struct mpoa_client *alloc_mpc(void)
 {
-        struct mpoa_client *mpc;
+	struct mpoa_client *mpc;
 
-        mpc = kmalloc(sizeof (struct mpoa_client), GFP_KERNEL);
-        if (mpc == NULL)
-                return NULL;
-        memset(mpc, 0, sizeof(struct mpoa_client));
-#if 0 /* compiler seems to barf on this */
-        mpc->ingress_lock = RW_LOCK_UNLOCKED;
-        mpc->egress_lock  = RW_LOCK_UNLOCKED;
-#endif
-        mpc->next = mpcs;
-        atm_mpoa_init_cache(mpc);
+	mpc = kmalloc(sizeof (struct mpoa_client), GFP_KERNEL);
+	if (mpc == NULL)
+		return NULL;
+	memset(mpc, 0, sizeof(struct mpoa_client));
+	mpc->ingress_lock = RW_LOCK_UNLOCKED;
+	mpc->egress_lock  = RW_LOCK_UNLOCKED;
+	mpc->next = mpcs;
+	atm_mpoa_init_cache(mpc);
 
 	mpc->parameters.mpc_p1 = MPC_P1;
 	mpc->parameters.mpc_p2 = MPC_P2;
@@ -281,9 +279,9 @@
 	mpc->parameters.mpc_p5 = MPC_P5; 
 	mpc->parameters.mpc_p6 = MPC_P6;
 	
-        mpcs = mpc;
+	mpcs = mpc;
 	
-        return mpc;
+	return mpc;
 }
 
 /*
@@ -295,58 +293,58 @@
  */
 static void start_mpc(struct mpoa_client *mpc, struct net_device *dev)
 {
-        
-        dprintk("mpoa: (%s) start_mpc:\n", mpc->dev->name); 
-        if (dev->hard_start_xmit == NULL) {
-                printk("mpoa: (%s) start_mpc: dev->hard_start_xmit == NULL, not starting\n",
-                       dev->name);
-                return;
-        }
-        mpc->old_hard_start_xmit = dev->hard_start_xmit;
-        dev->hard_start_xmit = mpc_send_packet;
+	
+	dprintk("mpoa: (%s) start_mpc:\n", mpc->dev->name); 
+	if (dev->hard_start_xmit == NULL) {
+		printk("mpoa: (%s) start_mpc: dev->hard_start_xmit == NULL, not starting\n",
+		       dev->name);
+		return;
+	}
+	mpc->old_hard_start_xmit = dev->hard_start_xmit;
+	dev->hard_start_xmit = mpc_send_packet;
 
-        return;
+	return;
 }
 
 static void stop_mpc(struct mpoa_client *mpc)
 {
-        
-        dprintk("mpoa: (%s) stop_mpc:", mpc->dev->name); 
+	
+	dprintk("mpoa: (%s) stop_mpc:", mpc->dev->name); 
 
-        /* Lets not nullify lec device's dev->hard_start_xmit */
-        if (mpc->dev->hard_start_xmit != mpc_send_packet) {
-                dprintk(" mpc already stopped, not fatal\n");
-                return;
-        }
-        dprintk("\n");
-        mpc->dev->hard_start_xmit = mpc->old_hard_start_xmit;
-        mpc->old_hard_start_xmit = NULL;
+	/* Lets not nullify lec device's dev->hard_start_xmit */
+	if (mpc->dev->hard_start_xmit != mpc_send_packet) {
+		dprintk(" mpc already stopped, not fatal\n");
+		return;
+	}
+	dprintk("\n");
+	mpc->dev->hard_start_xmit = mpc->old_hard_start_xmit;
+	mpc->old_hard_start_xmit = NULL;
 	/* close_shortcuts(mpc);    ??? FIXME */
-        
-        return;
+	
+	return;
 }
 
 static const char * __attribute__ ((unused)) mpoa_device_type_string(char type)
 {
-        switch(type) {
-        case NON_MPOA:
-                return "non-MPOA device";
-                break;
-        case MPS:
-                return "MPS";
-                break;
-        case MPC:
-                return "MPC";
-                break;
-        case MPS_AND_MPC:
-                return "both MPS and MPC";
-                break;
-        default:
-                return "unspecified (non-MPOA) device";
-                break;
-        }
+	switch(type) {
+	case NON_MPOA:
+		return "non-MPOA device";
+		break;
+	case MPS:
+		return "MPS";
+		break;
+	case MPC:
+		return "MPC";
+		break;
+	case MPS_AND_MPC:
+		return "both MPS and MPC";
+		break;
+	default:
+		return "unspecified (non-MPOA) device";
+		break;
+	}
 
-        return ""; /* not reached */
+	return ""; /* not reached */
 }
 
 /*
@@ -363,77 +361,77 @@
  *
  */
 static void lane2_assoc_ind(struct net_device *dev, uint8_t *mac_addr,
-                            uint8_t *tlvs, uint32_t sizeoftlvs)
+			    uint8_t *tlvs, uint32_t sizeoftlvs)
 {
-        uint32_t type;
-        uint8_t length, mpoa_device_type, number_of_mps_macs;
-        uint8_t *end_of_tlvs;
-        struct mpoa_client *mpc;
-        
-        mpoa_device_type = number_of_mps_macs = 0; /* silence gcc */
-        dprintk("mpoa: (%s) lane2_assoc_ind: received TLV(s), ", dev->name);
-        dprintk("total length of all TLVs %d\n", sizeoftlvs);
+	uint32_t type;
+	uint8_t length, mpoa_device_type, number_of_mps_macs;
+	uint8_t *end_of_tlvs;
+	struct mpoa_client *mpc;
+	
+	mpoa_device_type = number_of_mps_macs = 0; /* silence gcc */
+	dprintk("mpoa: (%s) lane2_assoc_ind: received TLV(s), ", dev->name);
+	dprintk("total length of all TLVs %d\n", sizeoftlvs);
 	mpc = find_mpc_by_lec(dev); /* Sampo-Fix: moved here from below */
-        if (mpc == NULL) {
-                printk("mpoa: (%s) lane2_assoc_ind: no mpc\n", dev->name);
-                return;
-        }
-        end_of_tlvs = tlvs + sizeoftlvs;
-        while (end_of_tlvs - tlvs >= 5) {
-                type = (tlvs[0] << 24) | (tlvs[1] << 16) | (tlvs[2] << 8) | tlvs[3];
-                length = tlvs[4];
-                tlvs += 5;
-                dprintk("    type 0x%x length %02x\n", type, length);
-                if (tlvs + length > end_of_tlvs) {
-                        printk("TLV value extends past its buffer, aborting parse\n");
-                        return;
-                }
-                
-                if (type == 0) {
-                        printk("mpoa: (%s) lane2_assoc_ind: TLV type was 0, returning\n", dev->name);
-                        return;
+	if (mpc == NULL) {
+		printk("mpoa: (%s) lane2_assoc_ind: no mpc\n", dev->name);
+		return;
+	}
+	end_of_tlvs = tlvs + sizeoftlvs;
+	while (end_of_tlvs - tlvs >= 5) {
+		type = (tlvs[0] << 24) | (tlvs[1] << 16) | (tlvs[2] << 8) | tlvs[3];
+		length = tlvs[4];
+		tlvs += 5;
+		dprintk("    type 0x%x length %02x\n", type, length);
+		if (tlvs + length > end_of_tlvs) {
+			printk("TLV value extends past its buffer, aborting parse\n");
+			return;
+		}
+		
+		if (type == 0) {
+			printk("mpoa: (%s) lane2_assoc_ind: TLV type was 0, returning\n", dev->name);
+			return;
 		}
 
-                if (type != TLV_MPOA_DEVICE_TYPE) {
-                        tlvs += length;
-                        continue;  /* skip other TLVs */
-                }
-                mpoa_device_type = *tlvs++;
-                number_of_mps_macs = *tlvs++;
-                dprintk("mpoa: (%s) MPOA device type '%s', ", dev->name, mpoa_device_type_string(mpoa_device_type));
-                if (mpoa_device_type == MPS_AND_MPC &&
-                    length < (42 + number_of_mps_macs*ETH_ALEN)) { /* :) */
-                        printk("\nmpoa: (%s) lane2_assoc_ind: short MPOA Device Type TLV\n",
-                               dev->name);
-                        continue;
-                }
-                if ((mpoa_device_type == MPS || mpoa_device_type == MPC)
-                    && length < 22 + number_of_mps_macs*ETH_ALEN) {
-                        printk("\nmpoa: (%s) lane2_assoc_ind: short MPOA Device Type TLV\n",
-                                dev->name);
-                        continue;
-                }
-                if (mpoa_device_type != MPS && mpoa_device_type != MPS_AND_MPC) {
-                        dprintk("ignoring non-MPS device\n");
-                        if (mpoa_device_type == MPC) tlvs += 20;
-                        continue;  /* we are only interested in MPSs */
-                }
-                if (number_of_mps_macs == 0 && mpoa_device_type == MPS_AND_MPC) {
-                        printk("\nmpoa: (%s) lane2_assoc_ind: MPS_AND_MPC has zero MACs\n", dev->name);
-                        continue;  /* someone should read the spec */
-                }
-                dprintk("this MPS has %d MAC addresses\n", number_of_mps_macs);
-                
-                /* ok, now we can go and tell our daemon the control address of MPS */
-                send_set_mps_ctrl_addr(tlvs, mpc);
-                
-                tlvs = copy_macs(mpc, mac_addr, tlvs, number_of_mps_macs, mpoa_device_type);
-                if (tlvs == NULL) return;
-        }
-        if (end_of_tlvs - tlvs != 0)
-                printk("mpoa: (%s) lane2_assoc_ind: ignoring %d bytes of trailing TLV carbage\n",
-                       dev->name, end_of_tlvs - tlvs);
-        return;
+		if (type != TLV_MPOA_DEVICE_TYPE) {
+			tlvs += length;
+			continue;  /* skip other TLVs */
+		}
+		mpoa_device_type = *tlvs++;
+		number_of_mps_macs = *tlvs++;
+		dprintk("mpoa: (%s) MPOA device type '%s', ", dev->name, mpoa_device_type_string(mpoa_device_type));
+		if (mpoa_device_type == MPS_AND_MPC &&
+		    length < (42 + number_of_mps_macs*ETH_ALEN)) { /* :) */
+			printk("\nmpoa: (%s) lane2_assoc_ind: short MPOA Device Type TLV\n",
+			       dev->name);
+			continue;
+		}
+		if ((mpoa_device_type == MPS || mpoa_device_type == MPC)
+		    && length < 22 + number_of_mps_macs*ETH_ALEN) {
+			printk("\nmpoa: (%s) lane2_assoc_ind: short MPOA Device Type TLV\n",
+				dev->name);
+			continue;
+		}
+		if (mpoa_device_type != MPS && mpoa_device_type != MPS_AND_MPC) {
+			dprintk("ignoring non-MPS device\n");
+			if (mpoa_device_type == MPC) tlvs += 20;
+			continue;  /* we are only interested in MPSs */
+		}
+		if (number_of_mps_macs == 0 && mpoa_device_type == MPS_AND_MPC) {
+			printk("\nmpoa: (%s) lane2_assoc_ind: MPS_AND_MPC has zero MACs\n", dev->name);
+			continue;  /* someone should read the spec */
+		}
+		dprintk("this MPS has %d MAC addresses\n", number_of_mps_macs);
+		
+		/* ok, now we can go and tell our daemon the control address of MPS */
+		send_set_mps_ctrl_addr(tlvs, mpc);
+		
+		tlvs = copy_macs(mpc, mac_addr, tlvs, number_of_mps_macs, mpoa_device_type);
+		if (tlvs == NULL) return;
+	}
+	if (end_of_tlvs - tlvs != 0)
+		printk("mpoa: (%s) lane2_assoc_ind: ignoring %d bytes of trailing TLV carbage\n",
+		       dev->name, end_of_tlvs - tlvs);
+	return;
 }
 
 /*
@@ -442,91 +440,94 @@
  * For a freshly allocated MPOA client mpc->mps_macs == 0.
  */
 static uint8_t *copy_macs(struct mpoa_client *mpc, uint8_t *router_mac,
-                          uint8_t *tlvs, uint8_t mps_macs, uint8_t device_type)
+			  uint8_t *tlvs, uint8_t mps_macs, uint8_t device_type)
 {
-        int num_macs;
-        num_macs = (mps_macs > 1) ? mps_macs : 1;
+	int num_macs;
+	num_macs = (mps_macs > 1) ? mps_macs : 1;
 
-        if (mpc->number_of_mps_macs != num_macs) { /* need to reallocate? */
-                if (mpc->number_of_mps_macs != 0) kfree(mpc->mps_macs);
-                mpc->number_of_mps_macs = 0;
-                mpc->mps_macs = kmalloc(num_macs*ETH_ALEN, GFP_KERNEL);
-                if (mpc->mps_macs == NULL) {
-                        printk("mpoa: (%s) copy_macs: out of mem\n", mpc->dev->name);
-                        return NULL;
-                }
-        }
-        memcpy(mpc->mps_macs, router_mac, ETH_ALEN);
-        tlvs += 20; if (device_type == MPS_AND_MPC) tlvs += 20;
-        if (mps_macs > 0)
-                memcpy(mpc->mps_macs, tlvs, mps_macs*ETH_ALEN);
-        tlvs += mps_macs*ETH_ALEN;
-        mpc->number_of_mps_macs = num_macs;
+	if (mpc->number_of_mps_macs != num_macs) { /* need to reallocate? */
+		if (mpc->number_of_mps_macs != 0) kfree(mpc->mps_macs);
+		mpc->number_of_mps_macs = 0;
+		mpc->mps_macs = kmalloc(num_macs*ETH_ALEN, GFP_KERNEL);
+		if (mpc->mps_macs == NULL) {
+			printk("mpoa: (%s) copy_macs: out of mem\n", mpc->dev->name);
+			return NULL;
+		}
+	}
+	memcpy(mpc->mps_macs, router_mac, ETH_ALEN);
+	tlvs += 20; if (device_type == MPS_AND_MPC) tlvs += 20;
+	if (mps_macs > 0)
+		memcpy(mpc->mps_macs, tlvs, mps_macs*ETH_ALEN);
+	tlvs += mps_macs*ETH_ALEN;
+	mpc->number_of_mps_macs = num_macs;
 
-        return tlvs;
+	return tlvs;
 }
 
-/* FIXME: tarvitsee työtä */
 static int send_via_shortcut(struct sk_buff *skb, struct mpoa_client *mpc)
 {
-        in_cache_entry *entry;
-        struct iphdr *iph;
-        char *buff;
-        uint32_t ipaddr = 0;
-
-        static struct {
-                struct llc_snap_hdr hdr;
-                uint32_t tag;
-        } tagged_llc_snap_hdr = {
-                {0xaa, 0xaa, 0x03, {0x00, 0x00, 0x00}, {0x88, 0x4c}},
-                0
-        };
+	in_cache_entry *entry;
+	struct iphdr *iph;
+	char *buff;
+	uint32_t ipaddr = 0;
+
+	static struct {
+		struct llc_snap_hdr hdr;
+		uint32_t tag;
+	} tagged_llc_snap_hdr = {
+		{0xaa, 0xaa, 0x03, {0x00, 0x00, 0x00}, {0x88, 0x4c}},
+		0
+	};
 
-        buff = skb->data + mpc->dev->hard_header_len;
-        iph = (struct iphdr *)buff;
+	buff = skb->data + mpc->dev->hard_header_len;
+	iph = (struct iphdr *)buff;
 	ipaddr = iph->daddr;
 
-        ddprintk("mpoa: (%s) send_via_shortcut: ipaddr 0x%x\n", mpc->dev->name, ipaddr);        
+	ddprintk("mpoa: (%s) send_via_shortcut: ipaddr 0x%x\n", mpc->dev->name, ipaddr);        
+
+	entry = mpc->in_ops->get(ipaddr, mpc);
+	if (entry == NULL) {
+		entry = mpc->in_ops->add_entry(ipaddr, mpc);
+		if (entry != NULL) mpc->in_ops->put(entry);
+		return 1;
+	}
+	if (mpc->in_ops->cache_hit(entry, mpc) != OPEN){   /* threshold not exceeded or VCC not ready */
+		ddprintk("mpoa: (%s) send_via_shortcut: cache_hit: returns != OPEN\n", mpc->dev->name);        
+		mpc->in_ops->put(entry);
+		return 1;
+	}
 
-        entry = mpc->in_ops->search(ipaddr, mpc);
-        if (entry == NULL) {
-                mpc->in_ops->new_entry(ipaddr, mpc);
-                return 1;
-        }
-        if (mpc->in_ops->cache_hit(entry, mpc) != OPEN){   /* threshold not exceeded or VCC not ready */
-                ddprintk("mpoa: (%s) send_via_shortcut: cache_hit: returns != OPEN\n", mpc->dev->name);        
-                return 1;
-        }
-
-        ddprintk("mpoa: (%s) send_via_shortcut: using shortcut\n", mpc->dev->name);        
-        /* MPOA spec A.1.4, MPOA client must decrement IP ttl at least by one */
-        if (iph->ttl <= 1) {
-              ddprintk("mpoa: (%s) send_via_shortcut: IP ttl = %u, using LANE\n", mpc->dev->name, iph->ttl);        
-              return 1;
-        }
-        iph->ttl--;
-        iph->check = 0;
-        iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
-
-        if (entry->ctrl_info.tag != 0) {
-                ddprintk("mpoa: (%s) send_via_shortcut: adding tag 0x%x\n", mpc->dev->name, entry->ctrl_info.tag);
-                tagged_llc_snap_hdr.tag = entry->ctrl_info.tag;
-                skb_pull(skb, ETH_HLEN);                       /* get rid of Eth header */
-                skb_push(skb, sizeof(tagged_llc_snap_hdr));    /* add LLC/SNAP header   */
-                memcpy(skb->data, &tagged_llc_snap_hdr, sizeof(tagged_llc_snap_hdr));
-        } else {
-                skb_pull(skb, ETH_HLEN);                        /* get rid of Eth header */
-                skb_push(skb, sizeof(struct llc_snap_hdr));     /* add LLC/SNAP header + tag  */
-                memcpy(skb->data, &llc_snap_mpoa_data, sizeof(struct llc_snap_hdr));
-        }
+	ddprintk("mpoa: (%s) send_via_shortcut: using shortcut\n", mpc->dev->name);        
+	/* MPOA spec A.1.4, MPOA client must decrement IP ttl at least by one */
+	if (iph->ttl <= 1) {
+		ddprintk("mpoa: (%s) send_via_shortcut: IP ttl = %u, using LANE\n", mpc->dev->name, iph->ttl);        
+		mpc->in_ops->put(entry);
+		return 1;
+	}
+	iph->ttl--;
+	iph->check = 0;
+	iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
+
+	if (entry->ctrl_info.tag != 0) {
+		ddprintk("mpoa: (%s) send_via_shortcut: adding tag 0x%x\n", mpc->dev->name, entry->ctrl_info.tag);
+		tagged_llc_snap_hdr.tag = entry->ctrl_info.tag;
+		skb_pull(skb, ETH_HLEN);                       /* get rid of Eth header */
+		skb_push(skb, sizeof(tagged_llc_snap_hdr));    /* add LLC/SNAP header   */
+		memcpy(skb->data, &tagged_llc_snap_hdr, sizeof(tagged_llc_snap_hdr));
+	} else {
+		skb_pull(skb, ETH_HLEN);                        /* get rid of Eth header */
+		skb_push(skb, sizeof(struct llc_snap_hdr));     /* add LLC/SNAP header + tag  */
+		memcpy(skb->data, &llc_snap_mpoa_data, sizeof(struct llc_snap_hdr));
+	}
 
-        atomic_add(skb->truesize, &entry->shortcut->tx_inuse);
+	atomic_add(skb->truesize, &entry->shortcut->tx_inuse);
 	ATM_SKB(skb)->iovcnt = 0; /* just to be safe ... */
 	ATM_SKB(skb)->atm_options = entry->shortcut->atm_options;
-        entry->shortcut->send(entry->shortcut, skb);
+	entry->shortcut->send(entry->shortcut, skb);
 	entry->packets_fwded++;
+	mpc->in_ops->put(entry);
 
-        return 0;
+	return 0;
 }
 
 /*
@@ -534,75 +535,77 @@
  */
 static int mpc_send_packet(struct sk_buff *skb, struct net_device *dev)
 {
-        int retval;
-        struct mpoa_client *mpc;
-        struct ethhdr *eth;
-        int i = 0;
-        
-        mpc = find_mpc_by_lec(dev); /* this should NEVER fail */
-        if(mpc == NULL) {
-	        printk("mpoa: (%s) mpc_send_packet: no MPC found\n", dev->name);
-                goto non_ip;
-	}
-
-        eth = (struct ethhdr *)skb->data;
-        if (eth->h_proto != htons(ETH_P_IP))
-                goto non_ip; /* Multi-Protocol Over ATM :-) */
-
-        while (i < mpc->number_of_mps_macs) {
-                if (memcmp(eth->h_dest, (mpc->mps_macs + i*ETH_ALEN), ETH_ALEN) == 0)
-                        if ( send_via_shortcut(skb, mpc) == 0 )           /* try shortcut */
-                                return 0;                                 /* success!     */
-                i++;
-        }
+	int retval;
+	struct mpoa_client *mpc;
+	struct ethhdr *eth;
+	int i = 0;
+	
+	mpc = find_mpc_by_lec(dev); /* this should NEVER fail */
+	if(mpc == NULL) {
+		printk("mpoa: (%s) mpc_send_packet: no MPC found\n", dev->name);
+		goto non_ip;
+	}
+
+	eth = (struct ethhdr *)skb->data;
+	if (eth->h_proto != htons(ETH_P_IP))
+		goto non_ip; /* Multi-Protocol Over ATM :-) */
+
+	while (i < mpc->number_of_mps_macs) {
+		if (memcmp(eth->h_dest, (mpc->mps_macs + i*ETH_ALEN), ETH_ALEN) == 0)
+			if ( send_via_shortcut(skb, mpc) == 0 )           /* try shortcut */
+				return 0;                                 /* success!     */
+		i++;
+	}
 
  non_ip:
-        retval = mpc->old_hard_start_xmit(skb,dev);
-        
-        return retval;
+	retval = mpc->old_hard_start_xmit(skb,dev);
+	
+	return retval;
 }
 
 int atm_mpoa_vcc_attach(struct atm_vcc *vcc, long arg)
 {
-        int bytes_left;
-        struct mpoa_client *mpc;
-        struct atmmpc_ioc ioc_data;
-        in_cache_entry *in_entry;
-        uint32_t  ipaddr;
+	int bytes_left;
+	struct mpoa_client *mpc;
+	struct atmmpc_ioc ioc_data;
+	in_cache_entry *in_entry;
+	uint32_t  ipaddr;
 	unsigned char *ip;
 
-        bytes_left = copy_from_user(&ioc_data, (void *)arg, sizeof(struct atmmpc_ioc));
-        if (bytes_left != 0) {
-                printk("mpoa: mpc_vcc_attach: Short read (missed %d bytes) from userland\n", bytes_left);
-                return -EFAULT;
-        }
-        ipaddr = ioc_data.ipaddr;
-        if (ioc_data.dev_num < 0 || ioc_data.dev_num >= MAX_LEC_ITF)
-                return -EINVAL;
-        
-        mpc = find_mpc_by_itfnum(ioc_data.dev_num);
-        if (mpc == NULL)
-                return -EINVAL;
-        
-        if (ioc_data.type == MPC_SOCKET_INGRESS) {
-                in_entry = mpc->in_ops->search(ipaddr, mpc);
-                if (in_entry == NULL || in_entry->entry_state < INGRESS_RESOLVED) {
-                        printk("mpoa: (%s) mpc_vcc_attach: did not find RESOLVED entry from ingress cache\n",
-                                mpc->dev->name);
-                        return -EINVAL;
-                }
+	bytes_left = copy_from_user(&ioc_data, (void *)arg, sizeof(struct atmmpc_ioc));
+	if (bytes_left != 0) {
+		printk("mpoa: mpc_vcc_attach: Short read (missed %d bytes) from userland\n", bytes_left);
+		return -EFAULT;
+	}
+	ipaddr = ioc_data.ipaddr;
+	if (ioc_data.dev_num < 0 || ioc_data.dev_num >= MAX_LEC_ITF)
+		return -EINVAL;
+	
+	mpc = find_mpc_by_itfnum(ioc_data.dev_num);
+	if (mpc == NULL)
+		return -EINVAL;
+	
+	if (ioc_data.type == MPC_SOCKET_INGRESS) {
+		in_entry = mpc->in_ops->get(ipaddr, mpc);
+		if (in_entry == NULL || in_entry->entry_state < INGRESS_RESOLVED) {
+			printk("mpoa: (%s) mpc_vcc_attach: did not find RESOLVED entry from ingress cache\n",
+				mpc->dev->name);
+			if (in_entry != NULL) mpc->in_ops->put(in_entry);
+			return -EINVAL;
+		}
 		ip = (unsigned char*)&in_entry->ctrl_info.in_dst_ip;
-                printk("mpoa: (%s) mpc_vcc_attach: attaching ingress SVC, entry = %u.%u.%u.%u\n",
-                       mpc->dev->name, ip[0], ip[1], ip[2], ip[3]);
-                in_entry->shortcut = vcc;
-        } else {
-                printk("mpoa: (%s) mpc_vcc_attach: attaching egress SVC\n", mpc->dev->name);
-        }
-        
-        vcc->proto_data = mpc->dev;
-        vcc->push = mpc_push;
+		printk("mpoa: (%s) mpc_vcc_attach: attaching ingress SVC, entry = %u.%u.%u.%u\n",
+		       mpc->dev->name, ip[0], ip[1], ip[2], ip[3]);
+		in_entry->shortcut = vcc;
+		mpc->in_ops->put(in_entry);
+	} else {
+		printk("mpoa: (%s) mpc_vcc_attach: attaching egress SVC\n", mpc->dev->name);
+	}
 
-        return 0;
+	vcc->proto_data = mpc->dev;
+	vcc->push = mpc_push;
+
+	return 0;
 }
 
 /*
@@ -610,251 +613,250 @@
  */
 static void mpc_vcc_close(struct atm_vcc *vcc, struct net_device *dev)
 {
-        struct mpoa_client *mpc;
-        in_cache_entry *in_entry;
-        eg_cache_entry *eg_entry;
-        
-        mpc = find_mpc_by_lec(dev);
-        if (mpc == NULL) {
-                printk("mpoa: (%s) mpc_vcc_close: close for unknown MPC\n", dev->name);
-                return;
-        }
-
-        dprintk("mpoa: (%s) mpc_vcc_close:\n", dev->name);
-        in_entry = mpc->in_ops->search_by_vcc(vcc, mpc);
-        if (in_entry) {
-                unsigned char *ip __attribute__ ((unused)) =
+	struct mpoa_client *mpc;
+	in_cache_entry *in_entry;
+	eg_cache_entry *eg_entry;
+	
+	mpc = find_mpc_by_lec(dev);
+	if (mpc == NULL) {
+		printk("mpoa: (%s) mpc_vcc_close: close for unknown MPC\n", dev->name);
+		return;
+	}
+
+	dprintk("mpoa: (%s) mpc_vcc_close:\n", dev->name);
+	in_entry = mpc->in_ops->get_by_vcc(vcc, mpc);
+	if (in_entry) {
+		unsigned char *ip __attribute__ ((unused)) =
 		    (unsigned char *)&in_entry->ctrl_info.in_dst_ip;
-	        dprintk("mpoa: (%s) mpc_vcc_close: ingress SVC closed ip = %u.%u.%u.%u\n",
-                       mpc->dev->name, ip[0], ip[1], ip[2], ip[3]);
-                in_entry->shortcut = NULL;
-        }
-        eg_entry = mpc->eg_ops->search_by_vcc(vcc, mpc);
-        if (eg_entry) {
-	        dprintk("mpoa: (%s) mpc_vcc_close: egress SVC closed\n", mpc->dev->name);
-                eg_entry->shortcut = NULL;
-        }
+		dprintk("mpoa: (%s) mpc_vcc_close: ingress SVC closed ip = %u.%u.%u.%u\n",
+		       mpc->dev->name, ip[0], ip[1], ip[2], ip[3]);
+		in_entry->shortcut = NULL;
+		mpc->in_ops->put(in_entry);
+	}
+	eg_entry = mpc->eg_ops->get_by_vcc(vcc, mpc);
+	if (eg_entry) {
+		dprintk("mpoa: (%s) mpc_vcc_close: egress SVC closed\n", mpc->dev->name);
+		eg_entry->shortcut = NULL;
+		mpc->eg_ops->put(eg_entry);
+	}
 
-        if (in_entry == NULL && eg_entry == NULL)
-                dprintk("mpoa: (%s) mpc_vcc_close:  unused vcc closed\n", dev->name);
+	if (in_entry == NULL && eg_entry == NULL)
+		dprintk("mpoa: (%s) mpc_vcc_close:  unused vcc closed\n", dev->name);
 
-        return;
+	return;
 }
 
 static void mpc_push(struct atm_vcc *vcc, struct sk_buff *skb)
 {
-        struct net_device *dev = (struct net_device *)vcc->proto_data;
-        struct sk_buff *new_skb;
-        eg_cache_entry *eg;
-        struct mpoa_client *mpc;
+	struct net_device *dev = (struct net_device *)vcc->proto_data;
+	struct sk_buff *new_skb;
+	eg_cache_entry *eg;
+	struct mpoa_client *mpc;
 	uint32_t tag;
-        char *tmp;
-        
-        ddprintk("mpoa: (%s) mpc_push:\n", dev->name);
-        if (skb == NULL) {
-                dprintk("mpoa: (%s) mpc_push: null skb, closing VCC\n", dev->name);
-                mpc_vcc_close(vcc, dev);
-                return;
-        }
-        
-        skb->dev = dev;
-        if (memcmp(skb->data, &llc_snap_mpoa_ctrl, sizeof(struct llc_snap_hdr)) == 0) {
-                dprintk("mpoa: (%s) mpc_push: control packet arrived\n", dev->name);
-                skb_queue_tail(&vcc->recvq, skb);           /* Pass control packets to daemon */
-                wake_up(&vcc->sleep);
-                return;
-        }
+	char *tmp;
+	
+	ddprintk("mpoa: (%s) mpc_push:\n", dev->name);
+	if (skb == NULL) {
+		dprintk("mpoa: (%s) mpc_push: null skb, closing VCC\n", dev->name);
+		mpc_vcc_close(vcc, dev);
+		return;
+	}
+	
+	skb->dev = dev;
+	if (memcmp(skb->data, &llc_snap_mpoa_ctrl, sizeof(struct llc_snap_hdr)) == 0) {
+		dprintk("mpoa: (%s) mpc_push: control packet arrived\n", dev->name);
+		skb_queue_tail(&vcc->recvq, skb);           /* Pass control packets to daemon */
+		wake_up(&vcc->sleep);
+		return;
+	}
 
-        /* data coming over the shortcut */
-        atm_return(vcc, skb->truesize);
+	/* data coming over the shortcut */
+	atm_return(vcc, skb->truesize);
 
 	mpc = find_mpc_by_lec(dev);
-        if (mpc == NULL) {
-                printk("mpoa: (%s) mpc_push: unknown MPC\n", dev->name);
-                return;
-        }
-
-        if (memcmp(skb->data, &llc_snap_mpoa_data_tagged, sizeof(struct llc_snap_hdr)) == 0) { /* MPOA tagged data */
-                ddprintk("mpoa: (%s) mpc_push: tagged data packet arrived\n", dev->name);
-
-        } else if (memcmp(skb->data, &llc_snap_mpoa_data, sizeof(struct llc_snap_hdr)) == 0) { /* MPOA data */
-                printk("mpoa: (%s) mpc_push: non-tagged data packet arrived\n", dev->name);
-                printk("           mpc_push: non-tagged data unsupported, purging\n");
-		kfree_skb(skb);
-                return;
-        } else {
-                printk("mpoa: (%s) mpc_push: garbage arrived, purging\n", dev->name);
-		kfree_skb(skb);
-                return;
-        }
+	if (mpc == NULL) {
+		printk("mpoa: (%s) mpc_push: unknown MPC\n", dev->name);
+		return;
+	}
 
-        tmp = skb->data + sizeof(struct llc_snap_hdr);
-        tag = *(uint32_t *)tmp;
+	if (memcmp(skb->data, &llc_snap_mpoa_data_tagged, sizeof(struct llc_snap_hdr)) == 0) { /* MPOA tagged data */
+		ddprintk("mpoa: (%s) mpc_push: tagged data packet arrived\n", dev->name);
 
-        eg = mpc->eg_ops->search_by_tag(tag, mpc);
-        if (eg == NULL) {
-                printk("mpoa: (%s) mpc_push: Didn't find egress cache entry, tag = %u\n",
-                       dev->name,tag);
-                purge_egress_shortcut(vcc, NULL);
-                kfree_skb(skb);
-                return;
-        }
-        
-        /*
-         * See if ingress MPC is using shortcut we opened as a return channel.
-         * This means we have a bi-directional vcc opened by us.
-         */ 
-        if (eg->shortcut == NULL) {
-                eg->shortcut = vcc;
-                printk("mpoa: (%s) mpc_push: egress SVC in use\n", dev->name);
-        }
-
-        skb_pull(skb, sizeof(struct llc_snap_hdr) + sizeof(tag)); /* get rid of LLC/SNAP header */
-        new_skb = skb_realloc_headroom(skb, eg->ctrl_info.DH_length); /* LLC/SNAP is shorter than MAC header :( */
-        kfree_skb(skb);
-        if (new_skb == NULL) return;
-        skb_push(new_skb, eg->ctrl_info.DH_length);     /* add MAC header */
-        memcpy(new_skb->data, eg->ctrl_info.DLL_header, eg->ctrl_info.DH_length);
-        new_skb->protocol = eth_type_trans(new_skb, dev);
-        new_skb->nh.raw = new_skb->data;
+	} else if (memcmp(skb->data, &llc_snap_mpoa_data, sizeof(struct llc_snap_hdr)) == 0) { /* MPOA data */
+		printk("mpoa: (%s) mpc_push: non-tagged data packet arrived\n", dev->name);
+		printk("           mpc_push: non-tagged data unsupported, purging\n");
+		dev_kfree_skb_any(skb);
+		return;
+	} else {
+		printk("mpoa: (%s) mpc_push: garbage arrived, purging\n", dev->name);
+		dev_kfree_skb_any(skb);
+		return;
+	}
+
+	tmp = skb->data + sizeof(struct llc_snap_hdr);
+	tag = *(uint32_t *)tmp;
+
+	eg = mpc->eg_ops->get_by_tag(tag, mpc);
+	if (eg == NULL) {
+		printk("mpoa: (%s) mpc_push: Didn't find egress cache entry, tag = %u\n",
+		       dev->name,tag);
+		purge_egress_shortcut(vcc, NULL);
+		dev_kfree_skb_any(skb);
+		return;
+	}
+	
+	/*
+	 * See if ingress MPC is using shortcut we opened as a return channel.
+	 * This means we have a bi-directional vcc opened by us.
+	 */ 
+	if (eg->shortcut == NULL) {
+		eg->shortcut = vcc;
+		printk("mpoa: (%s) mpc_push: egress SVC in use\n", dev->name);
+	}
+
+	skb_pull(skb, sizeof(struct llc_snap_hdr) + sizeof(tag)); /* get rid of LLC/SNAP header */
+	new_skb = skb_realloc_headroom(skb, eg->ctrl_info.DH_length); /* LLC/SNAP is shorter than MAC header :( */
+	dev_kfree_skb_any(skb);
+	if (new_skb == NULL){
+		mpc->eg_ops->put(eg);
+		return;
+	}
+	skb_push(new_skb, eg->ctrl_info.DH_length);     /* add MAC header */
+	memcpy(new_skb->data, eg->ctrl_info.DLL_header, eg->ctrl_info.DH_length);
+	new_skb->protocol = eth_type_trans(new_skb, dev);
+	new_skb->nh.raw = new_skb->data;
 
 	eg->latest_ip_addr = new_skb->nh.iph->saddr;
-        eg->packets_rcvd++;
-                
-        netif_rx(new_skb);
+	eg->packets_rcvd++;
+	mpc->eg_ops->put(eg);
 
-        return;
+	netif_rx(new_skb);
+
+	return;
 }
 
 static struct atmdev_ops mpc_ops = { /* only send is required */
-        close:	mpoad_close,
-        send:	msg_from_mpoad
+	close:	mpoad_close,
+	send:	msg_from_mpoad
 };
 
 static struct atm_dev mpc_dev = {
-        &mpc_ops,       /* device operations    */
-        NULL,           /* PHY operations       */
-        "mpc",          /* device type name     */
-        42,             /* device index (dummy) */
-        NULL,           /* VCC table            */
-        NULL,           /* last VCC             */
-        NULL,           /* per-device data      */
-        NULL,           /* private PHY data     */
-        { 0 },          /* device flags         */
-        NULL,           /* local ATM address    */
-        { 0 }           /* no ESI               */
-        /* rest of the members will be 0 */
+	&mpc_ops,       /* device operations    */
+	NULL,           /* PHY operations       */
+	"mpc",          /* device type name     */
+	42,             /* device index (dummy) */
+	NULL,           /* VCC table            */
+	NULL,           /* last VCC             */
+	NULL,           /* per-device data      */
+	NULL,           /* private PHY data     */
+	{ 0 },          /* device flags         */
+	NULL,           /* local ATM address    */
+	{ 0 }           /* no ESI               */
+	/* rest of the members will be 0 */
 };
 
 int atm_mpoa_mpoad_attach (struct atm_vcc *vcc, int arg)
 {
-        struct mpoa_client *mpc;
-        struct lec_priv *priv;
-        
-        if (mpcs == NULL) {
-                init_timer(&mpc_timer);
-                mpc_timer_refresh();
-
-                /* This lets us now how our LECs are doing */
-                register_netdevice_notifier(&mpoa_notifier);
-        }
-        
-        mpc = find_mpc_by_itfnum(arg);
-        if (mpc == NULL) {
-                dprintk("mpoa: mpoad_attach: allocating new mpc for itf %d\n", arg);
-                mpc = alloc_mpc();
-                mpc->dev_num = arg;
-                mpc->dev = find_lec_by_itfnum(arg); /* NULL if there was no lec */
-        }
-        if (mpc->mpoad_vcc) {
-                printk("mpoa: mpoad_attach: mpoad is already present for itf %d\n", arg);
-                return -EADDRINUSE;
-        }
-
-        if (mpc->dev) { /* check if the lec is LANE2 capable */
-                priv = (struct lec_priv *)mpc->dev->priv;
-                if (priv->lane_version < 2)
-                        mpc->dev = NULL;
+	struct mpoa_client *mpc;
+	struct lec_priv *priv;
+	
+	if (mpcs == NULL) {
+		init_timer(&mpc_timer);
+		mpc_timer_refresh();
+
+		/* This lets us now how our LECs are doing */
+		register_netdevice_notifier(&mpoa_notifier);
+	}
+	
+	mpc = find_mpc_by_itfnum(arg);
+	if (mpc == NULL) {
+		dprintk("mpoa: mpoad_attach: allocating new mpc for itf %d\n", arg);
+		mpc = alloc_mpc();
+		mpc->dev_num = arg;
+		mpc->dev = find_lec_by_itfnum(arg); /* NULL if there was no lec */
+	}
+	if (mpc->mpoad_vcc) {
+		printk("mpoa: mpoad_attach: mpoad is already present for itf %d\n", arg);
+		return -EADDRINUSE;
+	}
+
+	if (mpc->dev) { /* check if the lec is LANE2 capable */
+		priv = (struct lec_priv *)mpc->dev->priv;
+		if (priv->lane_version < 2)
+			mpc->dev = NULL;
 		else
-                        priv->lane2_ops->associate_indicator = lane2_assoc_ind;  
-        }
+			priv->lane2_ops->associate_indicator = lane2_assoc_ind;  
+	}
 
-        mpc->mpoad_vcc = vcc;
-        bind_vcc(vcc, &mpc_dev);
+	mpc->mpoad_vcc = vcc;
+	bind_vcc(vcc, &mpc_dev);
 	set_bit(ATM_VF_META,&vcc->flags);
 	set_bit(ATM_VF_READY,&vcc->flags);
 
-        if (mpc->dev) {
-                char empty[ATM_ESA_LEN];
-                memset(empty, 0, ATM_ESA_LEN);
-                
-                start_mpc(mpc, mpc->dev);
-                /* set address if mpcd e.g. gets killed and restarted.
-                 * If we do not do it now we have to wait for the next LE_ARP
-                 */
-                if ( memcmp(mpc->mps_ctrl_addr, empty, ATM_ESA_LEN) != 0 )
-                        send_set_mps_ctrl_addr(mpc->mps_ctrl_addr, mpc);
-        }
+	if (mpc->dev) {
+		char empty[ATM_ESA_LEN];
+		memset(empty, 0, ATM_ESA_LEN);
+		
+		start_mpc(mpc, mpc->dev);
+		/* set address if mpcd e.g. gets killed and restarted.
+		 * If we do not do it now we have to wait for the next LE_ARP
+		 */
+		if ( memcmp(mpc->mps_ctrl_addr, empty, ATM_ESA_LEN) != 0 )
+			send_set_mps_ctrl_addr(mpc->mps_ctrl_addr, mpc);
+	}
 
-        MOD_INC_USE_COUNT;
-        return arg;
+	MOD_INC_USE_COUNT;
+	return arg;
 }
 
 static void send_set_mps_ctrl_addr(char *addr, struct mpoa_client *mpc)
 {
-        struct k_message mesg;
+	struct k_message mesg;
 
-        memcpy (mpc->mps_ctrl_addr, addr, ATM_ESA_LEN);
-        
-        mesg.type = SET_MPS_CTRL_ADDR;
-        memcpy(mesg.MPS_ctrl, addr, ATM_ESA_LEN);
-        msg_to_mpoad(&mesg, mpc);
+	memcpy (mpc->mps_ctrl_addr, addr, ATM_ESA_LEN);
+	
+	mesg.type = SET_MPS_CTRL_ADDR;
+	memcpy(mesg.MPS_ctrl, addr, ATM_ESA_LEN);
+	msg_to_mpoad(&mesg, mpc);
 
-        return;
+	return;
 }
 
 static void mpoad_close(struct atm_vcc *vcc)
 {
-        unsigned long flags;
-        struct mpoa_client *mpc;
-        struct sk_buff *skb;
-
-        mpc = find_mpc_by_vcc(vcc);
-        if (mpc == NULL) {
-                printk("mpoa: mpoad_close: did not find MPC\n");
-                return;
-        }
-        if (!mpc->mpoad_vcc) {
-                printk("mpoa: mpoad_close: close for non-present mpoad\n");
-                return;
-        }
-        
-        mpc->mpoad_vcc = NULL;
-        if (mpc->dev) {
-                struct lec_priv *priv = (struct lec_priv *)mpc->dev->priv;
-                priv->lane2_ops->associate_indicator = NULL;
-                stop_mpc(mpc);
-        }
-
-        /* clear the caches */
-        write_lock_irqsave(&mpc->ingress_lock, flags);
-        while(mpc->in_ops->cache_remove(mpc->in_cache, mpc));
-        write_unlock_irqrestore(&mpc->ingress_lock, flags);
-
-        write_lock_irqsave(&mpc->egress_lock, flags);
-        while(mpc->eg_ops->cache_remove(mpc->eg_cache, mpc));
-        write_unlock_irqrestore(&mpc->egress_lock, flags);
+	struct mpoa_client *mpc;
+	struct sk_buff *skb;
+
+	mpc = find_mpc_by_vcc(vcc);
+	if (mpc == NULL) {
+		printk("mpoa: mpoad_close: did not find MPC\n");
+		return;
+	}
+	if (!mpc->mpoad_vcc) {
+		printk("mpoa: mpoad_close: close for non-present mpoad\n");
+		return;
+	}
+	
+	mpc->mpoad_vcc = NULL;
+	if (mpc->dev) {
+		struct lec_priv *priv = (struct lec_priv *)mpc->dev->priv;
+		priv->lane2_ops->associate_indicator = NULL;
+		stop_mpc(mpc);
+	}
+
+	mpc->in_ops->destroy_cache(mpc);
+	mpc->eg_ops->destroy_cache(mpc);
 
 	while ( (skb = skb_dequeue(&vcc->recvq)) ){
-                atm_return(vcc, skb->truesize);
-                kfree_skb(skb);
-        }
-        
-        printk("mpoa: (%s) going down\n",
-                (mpc->dev) ? mpc->dev->name : "<unknown>");
-        MOD_DEC_USE_COUNT;
+		atm_return(vcc, skb->truesize);
+		kfree_skb(skb);
+	}
+	
+	printk("mpoa: (%s) going down\n",
+		(mpc->dev) ? mpc->dev->name : "<unknown>");
+	MOD_DEC_USE_COUNT;
 
-        return;
+	return;
 }
 
 /*
@@ -862,163 +864,163 @@
  */
 static int msg_from_mpoad(struct atm_vcc *vcc, struct sk_buff *skb)
 {
-        
-        struct mpoa_client *mpc = find_mpc_by_vcc(vcc);
-        struct k_message *mesg = (struct k_message*)skb->data;
-        atomic_sub(skb->truesize+ATM_PDU_OVHD, &vcc->tx_inuse);
-        
-        if (mpc == NULL) {
-                printk("mpoa: msg_from_mpoad: no mpc found\n");
-                return 0;
-        }
-        dprintk("mpoa: (%s) msg_from_mpoad:", (mpc->dev) ? mpc->dev->name : "<unknown>");
-        switch(mesg->type) {
-        case MPOA_RES_REPLY_RCVD:
-	        dprintk(" mpoa_res_reply_rcvd\n");
-                MPOA_res_reply_rcvd(mesg, mpc);
-                break;
-        case MPOA_TRIGGER_RCVD:
-	        dprintk(" mpoa_trigger_rcvd\n");
-                MPOA_trigger_rcvd(mesg, mpc);
-                break;
-        case INGRESS_PURGE_RCVD:
-                dprintk(" nhrp_purge_rcvd\n");
-                ingress_purge_rcvd(mesg, mpc);
-                break;
-        case EGRESS_PURGE_RCVD:
-	        dprintk(" egress_purge_reply_rcvd\n");
-                egress_purge_rcvd(mesg, mpc);
-                break;
-        case MPS_DEATH:
-	        dprintk(" mps_death\n");
-                mps_death(mesg, mpc);
-                break;
-        case CACHE_IMPOS_RCVD:
-	        dprintk(" cache_impos_rcvd\n");
-                MPOA_cache_impos_rcvd(mesg, mpc);
-                break;
-        case SET_MPC_CTRL_ADDR:
-                dprintk(" set_mpc_ctrl_addr\n");
-                set_mpc_ctrl_addr_rcvd(mesg, mpc);
-                break;
+	
+	struct mpoa_client *mpc = find_mpc_by_vcc(vcc);
+	struct k_message *mesg = (struct k_message*)skb->data;
+	atomic_sub(skb->truesize+ATM_PDU_OVHD, &vcc->tx_inuse);
+	
+	if (mpc == NULL) {
+		printk("mpoa: msg_from_mpoad: no mpc found\n");
+		return 0;
+	}
+	dprintk("mpoa: (%s) msg_from_mpoad:", (mpc->dev) ? mpc->dev->name : "<unknown>");
+	switch(mesg->type) {
+	case MPOA_RES_REPLY_RCVD:
+		dprintk(" mpoa_res_reply_rcvd\n");
+		MPOA_res_reply_rcvd(mesg, mpc);
+		break;
+	case MPOA_TRIGGER_RCVD:
+		dprintk(" mpoa_trigger_rcvd\n");
+		MPOA_trigger_rcvd(mesg, mpc);
+		break;
+	case INGRESS_PURGE_RCVD:
+		dprintk(" nhrp_purge_rcvd\n");
+		ingress_purge_rcvd(mesg, mpc);
+		break;
+	case EGRESS_PURGE_RCVD:
+		dprintk(" egress_purge_reply_rcvd\n");
+		egress_purge_rcvd(mesg, mpc);
+		break;
+	case MPS_DEATH:
+		dprintk(" mps_death\n");
+		mps_death(mesg, mpc);
+		break;
+	case CACHE_IMPOS_RCVD:
+		dprintk(" cache_impos_rcvd\n");
+		MPOA_cache_impos_rcvd(mesg, mpc);
+		break;
+	case SET_MPC_CTRL_ADDR:
+		dprintk(" set_mpc_ctrl_addr\n");
+		set_mpc_ctrl_addr_rcvd(mesg, mpc);
+		break;
 	case SET_MPS_MAC_ADDR:
-	        dprintk(" set_mps_mac_addr\n");
+		dprintk(" set_mps_mac_addr\n");
 		set_mps_mac_addr_rcvd(mesg, mpc);
 		break;
 	case CLEAN_UP_AND_EXIT:
-                dprintk(" clean_up_and_exit\n");
-                clean_up(mesg, mpc, DIE);
-                break;
-        case RELOAD:
-                dprintk(" reload\n");
-                clean_up(mesg, mpc, RELOAD);
-                break;
-        case SET_MPC_PARAMS:
-                dprintk(" set_mpc_params\n");
-                mpc->parameters = mesg->content.params;
-                break;
-        default:
-                dprintk(" unknown message %d\n", mesg->type);
-                break;
-        }
-        kfree_skb(skb);
+		dprintk(" clean_up_and_exit\n");
+		clean_up(mesg, mpc, DIE);
+		break;
+	case RELOAD:
+		dprintk(" reload\n");
+		clean_up(mesg, mpc, RELOAD);
+		break;
+	case SET_MPC_PARAMS:
+		dprintk(" set_mpc_params\n");
+		mpc->parameters = mesg->content.params;
+		break;
+	default:
+		dprintk(" unknown message %d\n", mesg->type);
+		break;
+	}
+	kfree_skb(skb);
 
-        return 0;
+	return 0;
 }
 
+/* Remember that this function may not do things that sleep */
 int msg_to_mpoad(struct k_message *mesg, struct mpoa_client *mpc)
 {
-        struct sk_buff *skb;
+	struct sk_buff *skb;
+
+	if (mpc == NULL || !mpc->mpoad_vcc) {
+		printk("mpoa: msg_to_mpoad: mesg %d to a non-existent mpoad\n", mesg->type);
+		return -ENXIO;
+	}
 
-        if (mpc == NULL || !mpc->mpoad_vcc) {
-                printk("mpoa: msg_to_mpoad: mesg %d to a non-existent mpoad\n", mesg->type);
-                return -ENXIO;
-        }
-
-        skb = alloc_skb(sizeof(struct k_message), GFP_ATOMIC);
-        if (skb == NULL)
-                return -ENOMEM;
-        skb_put(skb, sizeof(struct k_message));
-        memcpy(skb->data, mesg, sizeof(struct k_message));
-        atm_force_charge(mpc->mpoad_vcc, skb->truesize);
-        skb_queue_tail(&mpc->mpoad_vcc->recvq, skb);
-        wake_up(&mpc->mpoad_vcc->sleep);
+	skb = alloc_skb(sizeof(struct k_message), GFP_ATOMIC);
+	if (skb == NULL)
+		return -ENOMEM;
+	skb_put(skb, sizeof(struct k_message));
+	memcpy(skb->data, mesg, sizeof(struct k_message));
+	atm_force_charge(mpc->mpoad_vcc, skb->truesize);
+	skb_queue_tail(&mpc->mpoad_vcc->recvq, skb);
+	wake_up(&mpc->mpoad_vcc->sleep);
 
-        return 0;
+	return 0;
 }
 
 static int mpoa_event_listener(struct notifier_block *mpoa_notifier, unsigned long event, void *dev_ptr)
 {
-        struct net_device *dev;
-        struct mpoa_client *mpc;
-        struct lec_priv *priv;
-
-        dev = (struct net_device *)dev_ptr;
-        if (dev->name == NULL || strncmp(dev->name, "lec", 3))
-                return NOTIFY_DONE; /* we are only interested in lec:s */
-        
-        switch (event) {
-        case NETDEV_REGISTER:       /* a new lec device was allocated */
-                priv = (struct lec_priv *)dev->priv;
-                if (priv->lane_version < 2)
-                        break;
-                priv->lane2_ops->associate_indicator = lane2_assoc_ind;
-                mpc = find_mpc_by_itfnum(priv->itfnum);
-                if (mpc == NULL) {
-                        dprintk("mpoa: mpoa_event_listener: allocating new mpc for %s\n",
-                               dev->name);
-                        mpc = alloc_mpc();
-                        if (mpc == NULL) {
-                                printk("mpoa: mpoa_event_listener: no new mpc");
-                                break;
-                        }
-                }
-                mpc->dev_num = priv->itfnum;
-                mpc->dev = dev;
-                dprintk("mpoa: (%s) was initialized\n", dev->name);
-                break;
-        case NETDEV_UNREGISTER:
-                /* the lec device was deallocated */
-                mpc = find_mpc_by_lec(dev);
-                if (mpc == NULL)
-                        break;
-                dprintk("mpoa: device (%s) was deallocated\n", dev->name);
-                stop_mpc(mpc);
-                mpc->dev = NULL;
-                break;
-        case NETDEV_UP:
-                /* the dev was ifconfig'ed up */
-                mpc = find_mpc_by_lec(dev);
-                if (mpc == NULL)
-                        break;
-                if (mpc->mpoad_vcc != NULL) {
-                        start_mpc(mpc, dev);
-                }
-                break;
-        case NETDEV_DOWN:
-                /* the dev was ifconfig'ed down */
-                /* this means dev->start == 0 and
-                 * the flow of packets from the
-                 * upper layer stops
-                 */
-                mpc = find_mpc_by_lec(dev);
-                if (mpc == NULL)
-                        break;
-                if (mpc->mpoad_vcc != NULL) {
-                        stop_mpc(mpc);
-                }
-                break;
-        case NETDEV_REBOOT:
-        case NETDEV_CHANGE:
-        case NETDEV_CHANGEMTU:
-        case NETDEV_CHANGEADDR:
-        case NETDEV_GOING_DOWN:
-                break;
-        default:
-                break;
-        }
+	struct net_device *dev;
+	struct mpoa_client *mpc;
+	struct lec_priv *priv;
+
+	dev = (struct net_device *)dev_ptr;
+	if (dev->name == NULL || strncmp(dev->name, "lec", 3))
+		return NOTIFY_DONE; /* we are only interested in lec:s */
+	
+	switch (event) {
+	case NETDEV_REGISTER:       /* a new lec device was allocated */
+		priv = (struct lec_priv *)dev->priv;
+		if (priv->lane_version < 2)
+			break;
+		priv->lane2_ops->associate_indicator = lane2_assoc_ind;
+		mpc = find_mpc_by_itfnum(priv->itfnum);
+		if (mpc == NULL) {
+			dprintk("mpoa: mpoa_event_listener: allocating new mpc for %s\n",
+			       dev->name);
+			mpc = alloc_mpc();
+			if (mpc == NULL) {
+				printk("mpoa: mpoa_event_listener: no new mpc");
+				break;
+			}
+		}
+		mpc->dev_num = priv->itfnum;
+		mpc->dev = dev;
+		dprintk("mpoa: (%s) was initialized\n", dev->name);
+		break;
+	case NETDEV_UNREGISTER:
+		/* the lec device was deallocated */
+		mpc = find_mpc_by_lec(dev);
+		if (mpc == NULL)
+			break;
+		dprintk("mpoa: device (%s) was deallocated\n", dev->name);
+		stop_mpc(mpc);
+		mpc->dev = NULL;
+		break;
+	case NETDEV_UP:
+		/* the dev was ifconfig'ed up */
+		mpc = find_mpc_by_lec(dev);
+		if (mpc == NULL)
+			break;
+		if (mpc->mpoad_vcc != NULL) {
+			start_mpc(mpc, dev);
+		}
+		break;
+	case NETDEV_DOWN:
+		/* the dev was ifconfig'ed down */
+		/* this means that the flow of packets from the
+		 * upper layer stops
+		 */
+		mpc = find_mpc_by_lec(dev);
+		if (mpc == NULL)
+			break;
+		if (mpc->mpoad_vcc != NULL) {
+			stop_mpc(mpc);
+		}
+		break;
+	case NETDEV_REBOOT:
+	case NETDEV_CHANGE:
+	case NETDEV_CHANGEMTU:
+	case NETDEV_CHANGEADDR:
+	case NETDEV_GOING_DOWN:
+		break;
+	default:
+		break;
+	}
 
-        return NOTIFY_DONE;
+	return NOTIFY_DONE;
 }
 
 /*
@@ -1027,33 +1029,36 @@
  */
 
 
-static void MPOA_trigger_rcvd(struct k_message *msg, struct mpoa_client *client)
+static void MPOA_trigger_rcvd(struct k_message *msg, struct mpoa_client *mpc)
 {
-        uint32_t dst_ip = msg->content.in_info.in_dst_ip;
-        in_cache_entry *entry;
+	uint32_t dst_ip = msg->content.in_info.in_dst_ip;
+	in_cache_entry *entry;
 
-	entry = client->in_ops->search(dst_ip, client);
-        if( entry == NULL ){
-                entry = client->in_ops->new_entry(dst_ip, client);
-                entry->entry_state = INGRESS_RESOLVING;
+	entry = mpc->in_ops->get(dst_ip, mpc);
+	if(entry == NULL){
+		entry = mpc->in_ops->add_entry(dst_ip, mpc);
+		entry->entry_state = INGRESS_RESOLVING;
 		msg->type = SND_MPOA_RES_RQST;
-                msg->content.in_info = entry->ctrl_info;
-		msg_to_mpoad(msg,client);
+		msg->content.in_info = entry->ctrl_info;
+		msg_to_mpoad(msg, mpc);
 		do_gettimeofday(&(entry->reply_wait));
+		mpc->in_ops->put(entry);
 		return;
-        }
-        
-        if( entry->entry_state == INGRESS_INVALID ){
-                entry->entry_state = INGRESS_RESOLVING;
+	}
+	
+	if(entry->entry_state == INGRESS_INVALID){
+		entry->entry_state = INGRESS_RESOLVING;
 		msg->type = SND_MPOA_RES_RQST;
-                msg->content.in_info = entry->ctrl_info;
-		msg_to_mpoad(msg,client);
+		msg->content.in_info = entry->ctrl_info;
+		msg_to_mpoad(msg, mpc);
 		do_gettimeofday(&(entry->reply_wait));
-                return;
-        }
-        
-        printk("mpoa: (%s) MPOA_trigger_rcvd: entry already in resolving state\n",
-                (client->dev) ? client->dev->name : "<unknown>");
+		mpc->in_ops->put(entry);
+		return;
+	}
+	
+	printk("mpoa: (%s) MPOA_trigger_rcvd: entry already in resolving state\n",
+		(mpc->dev) ? mpc->dev->name : "<unknown>");
+	mpc->in_ops->put(entry);
 	return;
 }
 
@@ -1061,30 +1066,36 @@
  * Things get complicated because we have to check if there's an egress
  * shortcut with suitable traffic parameters we could use. 
  */
-static void check_qos_and_open_shortcut(struct k_message *msg, struct mpoa_client *client, in_cache_entry *entry){
-        uint32_t dst_ip = msg->content.in_info.in_dst_ip;
-        unsigned char *ip __attribute__ ((unused)) = (unsigned char *)&dst_ip;
+static void check_qos_and_open_shortcut(struct k_message *msg, struct mpoa_client *client, in_cache_entry *entry)
+{
+	uint32_t dst_ip = msg->content.in_info.in_dst_ip;
+	unsigned char *ip __attribute__ ((unused)) = (unsigned char *)&dst_ip;
 	struct atm_mpoa_qos *qos = atm_mpoa_search_qos(dst_ip);
-	eg_cache_entry *eg_entry = client->eg_ops->search_by_src_ip(dst_ip, client);
+	eg_cache_entry *eg_entry = client->eg_ops->get_by_src_ip(dst_ip, client);
+
 	if(eg_entry && eg_entry->shortcut){
-	        if(eg_entry->shortcut->qos.txtp.traffic_class &
+		if(eg_entry->shortcut->qos.txtp.traffic_class &
 		   msg->qos.txtp.traffic_class &
 		   (qos ? qos->qos.txtp.traffic_class : ATM_UBR | ATM_CBR)){
-		            if(eg_entry->shortcut->qos.txtp.traffic_class == ATM_UBR)
-			            entry->shortcut = eg_entry->shortcut;
+			    if(eg_entry->shortcut->qos.txtp.traffic_class == ATM_UBR)
+				    entry->shortcut = eg_entry->shortcut;
 			    else if(eg_entry->shortcut->qos.txtp.max_pcr > 0)
-			            entry->shortcut = eg_entry->shortcut;
+				    entry->shortcut = eg_entry->shortcut;
 		}
 	 	if(entry->shortcut){
-		        dprintk("mpoa: (%s) using egress SVC to reach %d.%d.%d.%d\n",client->dev->name, ip[0], ip[1], ip[2], ip[3]);
+			dprintk("mpoa: (%s) using egress SVC to reach %u.%u.%u.%u\n",client->dev->name, NIPQUAD(ip));
+			client->eg_ops->put(eg_entry);
 			return;
 		}
 	}
+	if (eg_entry != NULL)
+		client->eg_ops->put(eg_entry);
+
 	/* No luck in the egress cache we must open an ingress SVC */
 	msg->type = OPEN_INGRESS_SVC;
 	if (qos && (qos->qos.txtp.traffic_class == msg->qos.txtp.traffic_class))
 	{
-	        msg->qos = qos->qos;
+		msg->qos = qos->qos;
 		printk("mpoa: (%s) trying to get a CBR shortcut\n",client->dev->name);
     	}
 	else memset(&msg->qos,0,sizeof(struct atm_qos));
@@ -1092,45 +1103,49 @@
 	return;
 }
 
-static void MPOA_res_reply_rcvd(struct k_message *msg, struct mpoa_client *client)
+static void MPOA_res_reply_rcvd(struct k_message *msg, struct mpoa_client *mpc)
 {
 	unsigned char *ip;
 
-        uint32_t dst_ip = msg->content.in_info.in_dst_ip;
-        in_cache_entry *entry = client->in_ops->search(dst_ip, client);
+	uint32_t dst_ip = msg->content.in_info.in_dst_ip;
+	in_cache_entry *entry = mpc->in_ops->get(dst_ip, mpc);
 	ip = (unsigned char *)&dst_ip;
-        dprintk("mpoa: (%s) MPOA_res_reply_rcvd: ip %d.%d.%d.%d\n", client->dev->name, ip[0], ip[1], ip[2], ip[3]);
-        ddprintk("mpoa: (%s) MPOA_res_reply_rcvd() entry = %p", client->dev->name, entry);
-        if(entry == NULL){
-                printk("\nmpoa: (%s) ARGH, received res. reply for an entry that doesn't exist.\n", client->dev->name);
-                return;
-        }
-        ddprintk(" entry_state = %d ", entry->entry_state);	
-
-        if (entry->entry_state == INGRESS_RESOLVED) {
-                printk("\nmpoa: (%s) MPOA_res_reply_rcvd for RESOLVED entry!\n", client->dev->name);
-                return;
-        }
-
-        entry->ctrl_info = msg->content.in_info;
-        do_gettimeofday(&(entry->tv));
-        do_gettimeofday(&(entry->reply_wait)); /* Used in refreshing func from now on */
-        entry->refresh_time = 0;
-        ddprintk("entry->shortcut = %p\n", entry->shortcut);
+	dprintk("mpoa: (%s) MPOA_res_reply_rcvd: ip %u.%u.%u.%u\n", mpc->dev->name, NIPQUAD(ip));
+	ddprintk("mpoa: (%s) MPOA_res_reply_rcvd() entry = %p", mpc->dev->name, entry);
+	if(entry == NULL){
+		printk("\nmpoa: (%s) ARGH, received res. reply for an entry that doesn't exist.\n", mpc->dev->name);
+		return;
+	}
+	ddprintk(" entry_state = %d ", entry->entry_state);	
+
+	if (entry->entry_state == INGRESS_RESOLVED) {
+		printk("\nmpoa: (%s) MPOA_res_reply_rcvd for RESOLVED entry!\n", mpc->dev->name);
+		mpc->in_ops->put(entry);
+		return;
+	}
+
+	entry->ctrl_info = msg->content.in_info;
+	do_gettimeofday(&(entry->tv));
+	do_gettimeofday(&(entry->reply_wait)); /* Used in refreshing func from now on */
+	entry->refresh_time = 0;
+	ddprintk("entry->shortcut = %p\n", entry->shortcut);
 
 	if(entry->entry_state == INGRESS_RESOLVING && entry->shortcut != NULL){
-	        entry->entry_state = INGRESS_RESOLVED; 
+		entry->entry_state = INGRESS_RESOLVED; 
+		mpc->in_ops->put(entry);
 		return; /* Shortcut already open... */
 	}
 
 	if (entry->shortcut != NULL) {
 		printk("mpoa: (%s) MPOA_res_reply_rcvd: entry->shortcut != NULL, impossible!\n",
-		       client->dev->name);
+		       mpc->dev->name);
+		mpc->in_ops->put(entry);
 		return;
 	}
 	
-	check_qos_and_open_shortcut(msg, client, entry);
+	check_qos_and_open_shortcut(msg, mpc, entry);
 	entry->entry_state = INGRESS_RESOLVED;
+	mpc->in_ops->put(entry);
 
 	return;
 
@@ -1138,73 +1153,79 @@
 
 static void ingress_purge_rcvd(struct k_message *msg, struct mpoa_client *mpc)
 {
-        uint32_t dst_ip = msg->content.in_info.in_dst_ip;
-        uint32_t mask = msg->ip_mask;
+	uint32_t dst_ip = msg->content.in_info.in_dst_ip;
+	uint32_t mask = msg->ip_mask;
 	unsigned char *ip = (unsigned char *)&dst_ip;
+	in_cache_entry *entry = mpc->in_ops->get_with_mask(dst_ip, mpc, mask);
 
-        in_cache_entry *entry = mpc->in_ops->search_with_mask(dst_ip, mpc, mask);
-        if( entry == NULL ){
-                printk("mpoa: (%s) ingress_purge_rcvd: recieved a purge for an entry that doesn't exist, ", mpc->dev->name);
-                printk("ip = %u.%u.%u.%u\n", ip[0], ip[1], ip[2], ip[3]);
-                return;
-        }
-	while(entry != NULL){
-	        dprintk("mpoa: (%s) ingress_purge_rcvd: removing an ingress entry, ip = %u.%u.%u.%u\n" ,
-		       mpc->dev->name, ip[0], ip[1], ip[2], ip[3]);
-		mpc->in_ops->cache_remove(entry, mpc);
-		entry = mpc->in_ops->search_with_mask(dst_ip, mpc, mask);
+	if(entry == NULL){
+		printk("mpoa: (%s) ingress_purge_rcvd: purge for a non-existing entry, ", mpc->dev->name);
+		printk("ip = %u.%u.%u.%u\n", ip[0], ip[1], ip[2], ip[3]);
+		return;
 	}
-        return;
+
+	do {
+		dprintk("mpoa: (%s) ingress_purge_rcvd: removing an ingress entry, ip = %u.%u.%u.%u\n" ,
+			mpc->dev->name, ip[0], ip[1], ip[2], ip[3]);
+		write_lock_bh(&mpc->ingress_lock);
+		mpc->in_ops->remove_entry(entry, mpc);
+		write_unlock_bh(&mpc->ingress_lock);
+		mpc->in_ops->put(entry);
+		entry = mpc->in_ops->get_with_mask(dst_ip, mpc, mask);
+	} while (entry != NULL);
+
+	return;
 } 
 
 static void egress_purge_rcvd(struct k_message *msg, struct mpoa_client *mpc)
 {
-        unsigned long flags;
-        uint32_t cache_id = msg->content.eg_info.cache_id;
-        eg_cache_entry *entry = mpc->eg_ops->search_by_cache_id(cache_id, mpc);
-        
-        if( entry == NULL ){
-                printk("mpoa: (%s) egress_purge_rcvd: received a purge reply for an entry that doesn't exist\n", mpc->dev->name);
-                return;
-        }
-
-        write_lock_irqsave(&mpc->egress_lock, flags);
-        mpc->eg_ops->cache_remove(entry, mpc);
-        write_unlock_irqrestore(&mpc->egress_lock, flags);
+	uint32_t cache_id = msg->content.eg_info.cache_id;
+	eg_cache_entry *entry = mpc->eg_ops->get_by_cache_id(cache_id, mpc);
+	
+	if (entry == NULL) {
+		dprintk("mpoa: (%s) egress_purge_rcvd: purge for a non-existing entry\n", mpc->dev->name);
+		return;
+	}
+
+	write_lock_irq(&mpc->egress_lock);
+	mpc->eg_ops->remove_entry(entry, mpc);
+	write_unlock_irq(&mpc->egress_lock);
 
-        return;
+	mpc->eg_ops->put(entry);
+
+	return;
 } 
 
 static void purge_egress_shortcut(struct atm_vcc *vcc, eg_cache_entry *entry)
 {
-        struct k_message *purge_msg;
-        struct sk_buff *skb;
+	struct k_message *purge_msg;
+	struct sk_buff *skb;
 
-        dprintk("mpoa: purge_egress_shortcut: entering\n");
-        if (vcc == NULL) {
-                printk("mpoa: purge_egress_shortcut: vcc == NULL\n");
-                return;
-        }
-
-        skb = alloc_skb(sizeof(struct k_message), GFP_ATOMIC);
-        if (skb == NULL) {
-                 printk("mpoa: purge_egress_shortcut: out of memory\n");
-                return;
-        }
-
-        skb_put(skb, sizeof(struct k_message));
-        memset(skb->data, 0, sizeof(struct k_message));
-        purge_msg = (struct k_message *)skb->data;
-        purge_msg->type = DATA_PLANE_PURGE;
-        if (entry != NULL)
-                purge_msg->content.eg_info = entry->ctrl_info;
-
-        atm_force_charge(vcc, skb->truesize);
-        skb_queue_tail(&vcc->recvq, skb);
-        wake_up(&vcc->sleep);
-        dprintk("mpoa: purge_egress_shortcut: exiting:\n");
+	dprintk("mpoa: purge_egress_shortcut: entering\n");
+	if (vcc == NULL) {
+		printk("mpoa: purge_egress_shortcut: vcc == NULL\n");
+		return;
+	}
 
-        return;
+	skb = alloc_skb(sizeof(struct k_message), GFP_ATOMIC);
+	if (skb == NULL) {
+		 printk("mpoa: purge_egress_shortcut: out of memory\n");
+		return;
+	}
+
+	skb_put(skb, sizeof(struct k_message));
+	memset(skb->data, 0, sizeof(struct k_message));
+	purge_msg = (struct k_message *)skb->data;
+	purge_msg->type = DATA_PLANE_PURGE;
+	if (entry != NULL)
+		purge_msg->content.eg_info = entry->ctrl_info;
+
+	atm_force_charge(vcc, skb->truesize);
+	skb_queue_tail(&vcc->recvq, skb);
+	wake_up(&vcc->sleep);
+	dprintk("mpoa: purge_egress_shortcut: exiting:\n");
+
+	return;
 }
 
 /*
@@ -1213,104 +1234,102 @@
  */
 static void mps_death( struct k_message * msg, struct mpoa_client * mpc )
 {
+	eg_cache_entry *entry;
 
-        unsigned long flags;
-        eg_cache_entry *entry;
+	dprintk("mpoa: (%s) mps_death:\n", mpc->dev->name);
 
-        dprintk("mpoa: (%s) mps_death:\n", mpc->dev->name);
+	if(memcmp(msg->MPS_ctrl, mpc->mps_ctrl_addr, ATM_ESA_LEN)){
+		printk("mpoa: (%s) mps_death: wrong MPS\n", mpc->dev->name);
+		return;
+	}
+
+	/* FIXME: This knows too much of the cache structure */
+	read_lock_irq(&mpc->egress_lock);
+	entry = mpc->eg_cache;
+	while (entry != NULL) {
+		purge_egress_shortcut(entry->shortcut, entry);
+		entry = entry->next;
+	}
+	read_unlock_irq(&mpc->egress_lock);
 
-        if(memcmp(msg->MPS_ctrl, mpc->mps_ctrl_addr, ATM_ESA_LEN)){
-                printk("mpoa: (%s) mps_death: wrong MPS\n", mpc->dev->name);
-                return;
-        }
-
-        entry = mpc->eg_cache;
-        while (entry != NULL) {
-                purge_egress_shortcut(entry->shortcut, entry);
-                entry = entry->next;
-        }
-
-        write_lock_irqsave(&mpc->ingress_lock, flags);
-        while(mpc->in_ops->cache_remove(mpc->in_cache, mpc));
-        write_unlock_irqrestore(&mpc->ingress_lock, flags);
-
-        write_lock_irqsave(&mpc->egress_lock, flags);
-        while(mpc->eg_ops->cache_remove(mpc->eg_cache, mpc));
-        write_unlock_irqrestore(&mpc->egress_lock, flags);
-
-        return;
-}
-
-static void MPOA_cache_impos_rcvd( struct k_message * msg, struct mpoa_client * mpc){
-
-        uint16_t holding_time;
-        unsigned long flags;
-        eg_cache_entry *entry = mpc->eg_ops->search_by_cache_id(msg->content.eg_info.cache_id, mpc);
-        
-        holding_time = msg->content.eg_info.holding_time;
-        dprintk("mpoa: (%s) MPOA_cache_impos_rcvd: entry = %p, holding_time = %u\n",
-               mpc->dev->name, entry, holding_time);
-        if(entry == NULL && holding_time) {
-                mpc->eg_ops->new_entry(msg, mpc);
-                return;
-        }
-        if(holding_time){
-                mpc->eg_ops->update(entry, holding_time);
-                return;
-        }
-        
-        write_lock_irqsave(&mpc->egress_lock, flags);
-        mpc->eg_ops->cache_remove(entry, mpc);
-        write_unlock_irqrestore(&mpc->egress_lock, flags);
+	mpc->in_ops->destroy_cache(mpc);
+	mpc->eg_ops->destroy_cache(mpc);
 
-        
-        return;
+	return;
+}
+
+static void MPOA_cache_impos_rcvd( struct k_message * msg, struct mpoa_client * mpc)
+{
+	uint16_t holding_time;
+	eg_cache_entry *entry = mpc->eg_ops->get_by_cache_id(msg->content.eg_info.cache_id, mpc);
+	
+	holding_time = msg->content.eg_info.holding_time;
+	dprintk("mpoa: (%s) MPOA_cache_impos_rcvd: entry = %p, holding_time = %u\n",
+	       mpc->dev->name, entry, holding_time);
+	if(entry == NULL && holding_time) {
+		entry = mpc->eg_ops->add_entry(msg, mpc);
+		mpc->eg_ops->put(entry);
+		return;
+	}
+	if(holding_time){
+		mpc->eg_ops->update(entry, holding_time);
+		return;
+	}
+	
+	write_lock_irq(&mpc->egress_lock);
+	mpc->eg_ops->remove_entry(entry, mpc);
+	write_unlock_irq(&mpc->egress_lock);
+
+	mpc->eg_ops->put(entry);
+	
+	return;
 }
 
 static void set_mpc_ctrl_addr_rcvd(struct k_message *mesg, struct mpoa_client *mpc)
 {
-        struct lec_priv *priv;
-        int i, retval ;
+	struct lec_priv *priv;
+	int i, retval ;
 
-        uint8_t tlv[4 + 1 + 1 + 1 + ATM_ESA_LEN];
+	uint8_t tlv[4 + 1 + 1 + 1 + ATM_ESA_LEN];
 
-        tlv[0] = 00; tlv[1] = 0xa0; tlv[2] = 0x3e; tlv[3] = 0x2a; /* type  */
-        tlv[4] = 1 + 1 + ATM_ESA_LEN;  /* length                           */
-        tlv[5] = 0x02;                 /* MPOA client                      */
-        tlv[6] = 0x00;                 /* number of MPS MAC addresses      */
-
-        memcpy(&tlv[7], mesg->MPS_ctrl, ATM_ESA_LEN); /* MPC ctrl ATM addr */
-        memcpy(mpc->our_ctrl_addr, mesg->MPS_ctrl, ATM_ESA_LEN);
-
-        dprintk("mpoa: (%s) setting MPC ctrl ATM address to ",
-               (mpc->dev) ? mpc->dev->name : "<unknown>");
-        for (i = 7; i < sizeof(tlv); i++)
-                dprintk("%02x ", tlv[i]);
-        dprintk("\n");
-
-        if (mpc->dev) {
-                priv = (struct lec_priv *)mpc->dev->priv;
-                retval = priv->lane2_ops->associate_req(mpc->dev, mpc->dev->dev_addr, tlv, sizeof(tlv));
-                if (retval == 0)
-                        printk("mpoa: (%s) MPOA device type TLV association failed\n", mpc->dev->name);
-                retval = priv->lane2_ops->resolve(mpc->dev, NULL, 1, NULL, NULL);
-                if (retval < 0)
-                        printk("mpoa: (%s) targetless LE_ARP request failed\n", mpc->dev->name);
-        }
-
-        return;
-}
-
-static void set_mps_mac_addr_rcvd(struct k_message *msg, struct mpoa_client *client){
-
-        if(client->number_of_mps_macs)
-                kfree(client->mps_macs);
-        client->number_of_mps_macs = 0;
+	tlv[0] = 00; tlv[1] = 0xa0; tlv[2] = 0x3e; tlv[3] = 0x2a; /* type  */
+	tlv[4] = 1 + 1 + ATM_ESA_LEN;  /* length                           */
+	tlv[5] = 0x02;                 /* MPOA client                      */
+	tlv[6] = 0x00;                 /* number of MPS MAC addresses      */
+
+	memcpy(&tlv[7], mesg->MPS_ctrl, ATM_ESA_LEN); /* MPC ctrl ATM addr */
+	memcpy(mpc->our_ctrl_addr, mesg->MPS_ctrl, ATM_ESA_LEN);
+
+	dprintk("mpoa: (%s) setting MPC ctrl ATM address to ",
+	       (mpc->dev) ? mpc->dev->name : "<unknown>");
+	for (i = 7; i < sizeof(tlv); i++)
+		dprintk("%02x ", tlv[i]);
+	dprintk("\n");
+
+	if (mpc->dev) {
+		priv = (struct lec_priv *)mpc->dev->priv;
+		retval = priv->lane2_ops->associate_req(mpc->dev, mpc->dev->dev_addr, tlv, sizeof(tlv));
+		if (retval == 0)
+			printk("mpoa: (%s) MPOA device type TLV association failed\n", mpc->dev->name);
+		retval = priv->lane2_ops->resolve(mpc->dev, NULL, 1, NULL, NULL);
+		if (retval < 0)
+			printk("mpoa: (%s) targetless LE_ARP request failed\n", mpc->dev->name);
+	}
+
+	return;
+}
+
+static void set_mps_mac_addr_rcvd(struct k_message *msg, struct mpoa_client *client)
+{
+
+	if(client->number_of_mps_macs)
+		kfree(client->mps_macs);
+	client->number_of_mps_macs = 0;
 	client->mps_macs = kmalloc(ETH_ALEN,GFP_KERNEL);
-        if (client->mps_macs == NULL) {
-	        printk("mpoa: set_mps_mac_addr_rcvd: out of memory\n");
-                return;
-        }
+	if (client->mps_macs == NULL) {
+		printk("mpoa: set_mps_mac_addr_rcvd: out of memory\n");
+		return;
+	}
 	client->number_of_mps_macs = 1;
 	memcpy(client->mps_macs, msg->MPS_ctrl, ETH_ALEN);
 	
@@ -1320,22 +1339,23 @@
 /*
  * purge egress cache and tell daemon to 'action' (DIE, RELOAD)
  */
-static void clean_up(struct k_message *msg, struct mpoa_client *mpc, int action){
+static void clean_up(struct k_message *msg, struct mpoa_client *mpc, int action)
+{
 
-        unsigned long flags;
-        eg_cache_entry *entry;
+	eg_cache_entry *entry;
 	msg->type = SND_EGRESS_PURGE;
 
 
-        read_lock_irqsave(&mpc->egress_lock, flags);
-        entry = mpc->eg_cache;
-	while(entry != NULL){
-	            msg->content.eg_info = entry->ctrl_info;
-                    dprintk("mpoa: cache_id %u\n", entry->ctrl_info.cache_id);
+	/* FIXME: This knows too much of the cache structure */
+	read_lock_irq(&mpc->egress_lock);
+	entry = mpc->eg_cache;
+	while (entry != NULL){
+		    msg->content.eg_info = entry->ctrl_info;
+		    dprintk("mpoa: cache_id %u\n", entry->ctrl_info.cache_id);
 		    msg_to_mpoad(msg, mpc);
 		    entry = entry->next;
 	}
-        read_unlock_irqrestore(&mpc->egress_lock, flags);
+	read_unlock_irq(&mpc->egress_lock);
 
 	msg->type = action;
 	msg_to_mpoad(msg, mpc);
@@ -1344,116 +1364,116 @@
 
 static void mpc_timer_refresh()
 {
-        mpc_timer.expires = jiffies + (MPC_P2 * HZ);
-        mpc_timer.data = mpc_timer.expires;
-        mpc_timer.function = mpc_cache_check;
-        add_timer(&mpc_timer);
-        
-        return;
+	mpc_timer.expires = jiffies + (MPC_P2 * HZ);
+	mpc_timer.data = mpc_timer.expires;
+	mpc_timer.function = mpc_cache_check;
+	add_timer(&mpc_timer);
+	
+	return;
 }
 
 static void mpc_cache_check( unsigned long checking_time  )
 {
-        struct mpoa_client *mpc = mpcs;
-        static unsigned long previous_resolving_check_time = 0;
-        static unsigned long previous_refresh_time = 0;
-        
-        while( mpc != NULL ){
-                mpc->in_ops->clear_count(mpc);
+	struct mpoa_client *mpc = mpcs;
+	static unsigned long previous_resolving_check_time = 0;
+	static unsigned long previous_refresh_time = 0;
+	
+	while( mpc != NULL ){
+		mpc->in_ops->clear_count(mpc);
 		mpc->eg_ops->clear_expired(mpc);
-                if(checking_time - previous_resolving_check_time > mpc->parameters.mpc_p4 * HZ ){
-                        mpc->in_ops->check_resolving(mpc);
-                        previous_resolving_check_time = checking_time;
-                }
-                if(checking_time - previous_refresh_time > mpc->parameters.mpc_p5 * HZ ){
-                        mpc->in_ops->refresh(mpc);
-                        previous_refresh_time = checking_time;
-                }
-                mpc = mpc->next;
-        }
-        mpc_timer_refresh();
-        
-        return;
+		if(checking_time - previous_resolving_check_time > mpc->parameters.mpc_p4 * HZ ){
+			mpc->in_ops->check_resolving(mpc);
+			previous_resolving_check_time = checking_time;
+		}
+		if(checking_time - previous_refresh_time > mpc->parameters.mpc_p5 * HZ ){
+			mpc->in_ops->refresh(mpc);
+			previous_refresh_time = checking_time;
+		}
+		mpc = mpc->next;
+	}
+	mpc_timer_refresh();
+	
+	return;
 }
 
 void atm_mpoa_init_ops(struct atm_mpoa_ops *ops)
 {
-        ops->mpoad_attach = atm_mpoa_mpoad_attach;
-        ops->vcc_attach = atm_mpoa_vcc_attach;
+	ops->mpoad_attach = atm_mpoa_mpoad_attach;
+	ops->vcc_attach = atm_mpoa_vcc_attach;
 
 #ifdef CONFIG_PROC_FS
 	if(mpc_proc_init() != 0)
-	        printk(KERN_INFO "mpoa: failed to initialize /proc/mpoa\n");
+		printk(KERN_INFO "mpoa: failed to initialize /proc/mpoa\n");
 	else
-	        printk(KERN_INFO "mpoa: /proc/mpoa initialized\n");
+		printk(KERN_INFO "mpoa: /proc/mpoa initialized\n");
 #endif
 
-        printk("mpc.c: " __DATE__ " " __TIME__ " initialized\n");
+	printk("mpc.c: " __DATE__ " " __TIME__ " initialized\n");
 
-        return;
+	return;
 }
 
 #ifdef MODULE
 int init_module(void)
 {
-        extern struct atm_mpoa_ops atm_mpoa_ops;
+	extern struct atm_mpoa_ops atm_mpoa_ops;
 
 	atm_mpoa_init_ops(&atm_mpoa_ops);
 
-        return 0;
+	return 0;
 }
 
 void cleanup_module(void)
 {
-        extern struct atm_mpoa_ops atm_mpoa_ops;
-        struct mpoa_client *mpc, *tmp;
-        struct atm_mpoa_qos *qos, *nextqos;
-        struct lec_priv *priv;
-
-        if (MOD_IN_USE) {
-                printk("mpc.c: module in use\n");
-                return;
-        }
+	extern struct atm_mpoa_ops atm_mpoa_ops;
+	struct mpoa_client *mpc, *tmp;
+	struct atm_mpoa_qos *qos, *nextqos;
+	struct lec_priv *priv;
+
+	if (MOD_IN_USE) {
+		printk("mpc.c: module in use\n");
+		return;
+	}
 #ifdef CONFIG_PROC_FS
 	mpc_proc_clean();
 #endif
 
-        del_timer(&mpc_timer);
-        unregister_netdevice_notifier(&mpoa_notifier);
-        atm_mpoa_ops.mpoad_attach = NULL;
-        atm_mpoa_ops.vcc_attach = NULL;
-
-        mpc = mpcs;
-        mpcs = NULL;
-        while (mpc != NULL) {
-                tmp = mpc->next;
-                if (mpc->dev != NULL) {
-                        stop_mpc(mpc);
-                        priv = (struct lec_priv *)mpc->dev->priv;
-                        if (priv->lane2_ops != NULL)
-                                priv->lane2_ops->associate_indicator = NULL;
-                }
-                ddprintk("mpoa: cleanup_module: about to clear caches\n");
-                while(mpc->in_ops->cache_remove(mpc->in_cache, mpc));
-                while(mpc->eg_ops->cache_remove(mpc->eg_cache, mpc));        
-                ddprintk("mpoa: cleanup_module: caches cleared\n");
-                kfree(mpc->mps_macs);
-                memset(mpc, 0, sizeof(struct mpoa_client));
-                ddprintk("mpoa: cleanup_module: about to kfree %p\n", mpc);
-                kfree(mpc);
-                ddprintk("mpoa: cleanup_module: next mpc is at %p\n", tmp);
-                mpc = tmp;
-        }
-
-        qos = qos_head;
-        qos_head = NULL;
-        while (qos != NULL) {
-                nextqos = qos->next;
-                dprintk("mpoa: cleanup_module: freeing qos entry %p\n", qos);
-                kfree(qos);
-                qos = nextqos;
-        }
+	del_timer(&mpc_timer);
+	unregister_netdevice_notifier(&mpoa_notifier);
+	atm_mpoa_ops.mpoad_attach = NULL;
+	atm_mpoa_ops.vcc_attach = NULL;
+
+	mpc = mpcs;
+	mpcs = NULL;
+	while (mpc != NULL) {
+		tmp = mpc->next;
+		if (mpc->dev != NULL) {
+			stop_mpc(mpc);
+			priv = (struct lec_priv *)mpc->dev->priv;
+			if (priv->lane2_ops != NULL)
+				priv->lane2_ops->associate_indicator = NULL;
+		}
+		ddprintk("mpoa: cleanup_module: about to clear caches\n");
+		mpc->in_ops->destroy_cache(mpc);
+		mpc->eg_ops->destroy_cache(mpc);
+		ddprintk("mpoa: cleanup_module: caches cleared\n");
+		kfree(mpc->mps_macs);
+		memset(mpc, 0, sizeof(struct mpoa_client));
+		ddprintk("mpoa: cleanup_module: about to kfree %p\n", mpc);
+		kfree(mpc);
+		ddprintk("mpoa: cleanup_module: next mpc is at %p\n", tmp);
+		mpc = tmp;
+	}
 
-        return;
+	qos = qos_head;
+	qos_head = NULL;
+	while (qos != NULL) {
+		nextqos = qos->next;
+		dprintk("mpoa: cleanup_module: freeing qos entry %p\n", qos);
+		kfree(qos);
+		qos = nextqos;
+	}
+
+	return;
 }
 #endif /* MODULE */

FUNET's LINUX-ADM group, linux-adm@nic.funet.fi
TCL-scripts by Sam Shen (who was at: slshen@lbl.gov)